Sign upLogin

princelab/mspire

View on GitHub
Star
lib/mspire/mzml/data_array.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method from_xml has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def self.from_xml(xml, link)
    da = self.new 
    binary_n = da.describe_from_xml!(xml, link[:ref_hash])

    if (dp_id = xml[:dataProcessingRef])
Severity: Minor
Found in lib/mspire/mzml/data_array.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_binary has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def to_binary
    # single pass over params for speed
    pack_code = nil
    compression = nil
    each_accessionable_param do |param|
Severity: Minor
Found in lib/mspire/mzml/data_array.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_binary has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def to_binary
    # single pass over params for speed
    pack_code = nil
    compression = nil
    each_accessionable_param do |param|
Severity: Minor
Found in lib/mspire/mzml/data_array.rb - About 1 hr to fix

    Method from_xml has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.from_xml(xml, link)
    da = self.new 
    binary_n = da.describe_from_xml!(xml, link[:ref_hash])

    if (dp_id = xml[:dataProcessingRef])
    Severity: Minor
    Found in lib/mspire/mzml/data_array.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status