Sign upLogin

project-capo/amber-python-drivers

View on GitHub
Star
src/amberdriver/drive_to_point/drive_to_point_logic.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function find_local_minima_func has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def find_local_minima_func(points):
    prev_distance = None
    minimum_distance = None
    minimum_angle = None
    minimas = []
Severity: Minor
Found in src/amberdriver/drive_to_point/drive_to_point_logic.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_absolute_location has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def update_absolute_location(self, location):
        self.__last_update_ts = time.time()
        x, y, probability, angle, _ = location
        if x is None or y is None or probability is None or angle is None:
            return
Severity: Minor
Found in src/amberdriver/drive_to_point/drive_to_point_logic.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if (self.__absolute_x is not None and abs(x - self.__absolute_x) > 0.25) or \
                (self.__absolute_y is not None and abs(y - self.__absolute_y) > 0.25) or \
                (self.__absolute_angle is not None and abs(angle - self.__absolute_angle) > 0.2617993877991494):
            return
        angle = normalize_angle(angle)
Severity: Major
Found in src/amberdriver/drive_to_point/drive_to_point_logic.py - About 40 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                x = self.__relative_x + speed_left * delta_timestamp * math.cos(self.__relative_angle)
    Severity: Minor
    Found in src/amberdriver/drive_to_point/drive_to_point_logic.py and 1 other location - About 35 mins to fix
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 91..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                angle = (1.0 - probability) * self.__relative_angle + probability * self.__absolute_angle
    Severity: Minor
    Found in src/amberdriver/drive_to_point/drive_to_point_logic.py and 2 other locations - About 35 mins to fix
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 114..114
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 115..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                y = self.__relative_y + speed_right * delta_timestamp * math.sin(self.__relative_angle)
    Severity: Minor
    Found in src/amberdriver/drive_to_point/drive_to_point_logic.py and 1 other location - About 35 mins to fix
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 90..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                x = (1.0 - probability) * self.__relative_x + probability * self.__absolute_x
    Severity: Minor
    Found in src/amberdriver/drive_to_point/drive_to_point_logic.py and 2 other locations - About 35 mins to fix
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 115..115
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 116..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                y = (1.0 - probability) * self.__relative_y + probability * self.__absolute_y
    Severity: Minor
    Found in src/amberdriver/drive_to_point/drive_to_point_logic.py and 2 other locations - About 35 mins to fix
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 114..114
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 116..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (self.__absolute_x is not None and abs(x - self.__absolute_x) > 0.25) or \
    Severity: Minor
    Found in src/amberdriver/drive_to_point/drive_to_point_logic.py and 2 other locations - About 30 mins to fix
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 76..76
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 77..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    (self.__absolute_angle is not None and abs(angle - self.__absolute_angle) > 0.2617993877991494):
    Severity: Minor
    Found in src/amberdriver/drive_to_point/drive_to_point_logic.py and 2 other locations - About 30 mins to fix
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 75..75
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 76..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    (self.__absolute_y is not None and abs(y - self.__absolute_y) > 0.25) or \
    Severity: Minor
    Found in src/amberdriver/drive_to_point/drive_to_point_logic.py and 2 other locations - About 30 mins to fix
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 75..75
    src/amberdriver/drive_to_point/drive_to_point_logic.py on lines 77..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status