propelorm/Propel2

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function addRetrieveRoot(string &$script): void
    {
        $queryClassName = $this->queryClassName;
        $objectClassName = $this->objectClassName;
        $useScope = $this->behavior->useScope();

Found in src/Propel/Generator/Behavior/NestedSet/NestedSetBehaviorQueryBuilderModifier.php and 1 other location - About 2 hrs to fix

Read up
Read up

src/Propel/Generator/Behavior/NestedSet/NestedSetBehaviorQueryBuilderModifier.php on lines 616..651

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 129.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Method `parseTables` has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function parseTables(array &$tableWraps, Database $database, ?Table $filterTable = null): void
    {
        $params = [];

        $sql = "

Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 2 hrs to fix

Method `addCrossFKCount` has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addCrossFKCount(string &$script, CrossForeignKeys $crossFKs): void
    {
        $refFK = $crossFKs->getIncomingForeignKey();
        $selfRelationName = $this->getFKPhpNameAffix($refFK, false);

Found in src/Propel/Generator/Builder/Om/ObjectBuilder.php - About 2 hrs to fix

File `SluggableBehavior.php` has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * MIT License. This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE

Found in src/Propel/Generator/Behavior/Sluggable/SluggableBehavior.php - About 2 hrs to fix

Method `addFixLevels` has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addFixLevels(string &$script): void
    {
        $objectClassName = $this->objectClassName;
        $queryClassName = $this->queryClassName;
        $tableMapClassName = $this->tableMapClassName;

Found in src/Propel/Generator/Behavior/NestedSet/NestedSetBehaviorQueryBuilderModifier.php - About 2 hrs to fix

File `ArchivableBehavior.php` has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * MIT License. This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE

Found in src/Propel/Generator/Behavior/Archivable/ArchivableBehavior.php - About 2 hrs to fix

Consider simplifying this complex logical expression.
Open

            if (
                $this->offset === $criteria->getOffset()
                && $this->limit === $criteria->getLimit()
                && $this->ignoreCase === $criteria->isIgnoreCase()
                && $this->singleRecord === $criteria->isSingleRecord()

Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 hrs to fix

`AbstractCriterion` has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractCriterion
{
    /**
     * @var string
     */

Found in src/Propel/Runtime/ActiveQuery/Criterion/AbstractCriterion.php - About 2 hrs to fix

Method `addReload` has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addReload(string &$script): void
    {
        $table = $this->getTable();
        $script .= "
    /**

Found in src/Propel/Generator/Builder/Om/ObjectBuilder.php - About 2 hrs to fix

Method `addCrossFKRemove` has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addCrossFKRemove(string &$script, CrossForeignKeys $crossFKs): void
    {
        $relCol = $this->getCrossFKsPhpNameAffix($crossFKs, true);
        if (1 < count($crossFKs->getCrossForeignKeys()) || $crossFKs->getUnclassifiedPrimaryKeys()) {
            $collName = 'combination' . ucfirst($this->getCrossFKsVarName($crossFKs));

Found in src/Propel/Generator/Builder/Om/ObjectBuilder.php - About 2 hrs to fix

Method `loadDataModels` has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function loadDataModels(): void
    {
        $schemas = [];
        $totalNbTables = 0;
        $dataModelFiles = $this->getSchemas();

Found in src/Propel/Generator/Manager/AbstractManager.php - About 2 hrs to fix

Function `createSelectSqlPart` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function createSelectSqlPart(Criteria $criteria, array &$fromClause, bool $aliasAll = false): string
    {
        $selectClause = [];

        if ($aliasAll) {

Found in src/Propel/Runtime/Adapter/Pdo/PdoAdapter.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `getGroupBy` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function getGroupBy(Criteria $criteria): string
    {
        $groupBy = $criteria->getGroupByColumns();

        if ($groupBy) {

Found in src/Propel/Runtime/Adapter/Pdo/PgsqlAdapter.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `mergeWith` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function mergeWith(self $criteria, ?string $operator = null)
    {
        // merge limit
        $limit = $criteria->getLimit();
        if ($limit && $this->getLimit() === -1) {

Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `replaceNames` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function replaceNames(string &$sql): bool
    {
        $this->replacedColumns = [];
        $this->currentAlias = '';
        $this->foundMatch = false;

Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `convertDOMElementToArray` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    protected function convertDOMElementToArray(DOMNode $data): array
    {
        $array = [];
        $elementNames = [];
        /** @var \DOMElement $element */

Found in src/Propel/Runtime/Parser/XmlParser.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `parseTables` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseTables(array &$tableWraps, Database $database, ?Table $filterTable = null): void
    {
        $params = [];

        $sql = "

Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `addIndexes` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    protected function addIndexes(Table $table): void
    {
        /** @var \PDOStatement $stmt */
        $stmt = $this->dbh->query(sprintf('SHOW INDEX FROM %s', $this->getPlatform()->doQuoting($table->getName())));

Found in src/Propel/Generator/Reverse/MysqlSchemaParser.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `addDoInsertBodyWithIdMethod` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    protected function addDoInsertBodyWithIdMethod(): string
    {
        $table = $this->getTable();
        $script = '';
        foreach ($table->getPrimaryKey() as $col) {

Found in src/Propel/Generator/Builder/Om/ObjectBuilder.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `addFindPkSimple` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    protected function addFindPkSimple(string &$script): void
    {
        $table = $this->getTable();

        // this method is not needed if the table has no primary key

Found in src/Propel/Generator/Builder/Om/QueryBuilder.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading