propelorm/Propel2

View on GitHub

Showing 764 of 764 total issues

File ObjectBuilder.php has 4033 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * MIT License. This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
Severity: Major
Found in src/Propel/Generator/Builder/Om/ObjectBuilder.php - About 1 wk to fix

    ObjectBuilder has 206 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ObjectBuilder extends AbstractObjectBuilder
    {
        /**
         * Returns the package for the base object classes.
         *
    Severity: Major
    Found in src/Propel/Generator/Builder/Om/ObjectBuilder.php - About 4 days to fix

      File Criteria.php has 1384 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      /**
       * MIT License. This file is part of the Propel package.
       * For the full copyright and license information, please view the LICENSE
      Severity: Major
      Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 3 days to fix

        File QueryBuilder.php has 1129 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        /**
         * MIT License. This file is part of the Propel package.
         * For the full copyright and license information, please view the LICENSE
        Severity: Major
        Found in src/Propel/Generator/Builder/Om/QueryBuilder.php - About 2 days to fix

          File ModelCriteria.php has 1080 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          /**
           * MIT License. This file is part of the Propel package.
           * For the full copyright and license information, please view the LICENSE
          Severity: Major
          Found in src/Propel/Runtime/ActiveQuery/ModelCriteria.php - About 2 days to fix

            File Table.php has 1021 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            /**
             * MIT License. This file is part of the Propel package.
             * For the full copyright and license information, please view the LICENSE
            Severity: Major
            Found in src/Propel/Generator/Model/Table.php - About 2 days to fix

              File NestedSetBehaviorObjectBuilderModifier.php has 943 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              
              /**
               * MIT License. This file is part of the Propel package.
               * For the full copyright and license information, please view the LICENSE

                Table has 119 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Table extends ScopedMappingModel implements IdMethod
                {
                    use BehaviorableTrait;
                
                    /**
                Severity: Major
                Found in src/Propel/Generator/Model/Table.php - About 2 days to fix

                  File TableMapBuilder.php has 892 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  /**
                   * MIT License. This file is part of the Propel package.
                   * For the full copyright and license information, please view the LICENSE
                  Severity: Major
                  Found in src/Propel/Generator/Builder/Om/TableMapBuilder.php - About 2 days to fix

                    Column has 109 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class Column extends MappingModel
                    {
                        public const DEFAULT_TYPE = 'VARCHAR';
                        public const DEFAULT_VISIBILITY = 'public';
                        public const CONSTANT_PREFIX = 'COL_';
                    Severity: Major
                    Found in src/Propel/Generator/Model/Column.php - About 2 days to fix

                      Criteria has 108 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class Criteria
                      {
                          public const EQUAL = '=';
                      
                          public const NOT_EQUAL = '<>';
                      Severity: Major
                      Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 days to fix

                        File DefaultPlatform.php has 850 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        
                        /**
                         * MIT License. This file is part of the Propel package.
                         * For the full copyright and license information, please view the LICENSE
                        Severity: Major
                        Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 2 days to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              private static $mappingToPHPNativeMap = [
                                  self::CHAR => self::CHAR_NATIVE_TYPE,
                                  self::VARCHAR => self::VARCHAR_NATIVE_TYPE,
                                  self::LONGVARCHAR => self::LONGVARCHAR_NATIVE_TYPE,
                                  self::CLOB => self::CLOB_NATIVE_TYPE,
                          Severity: Major
                          Found in src/Propel/Generator/Model/PropelTypes.php and 1 other location - About 2 days to fix
                          src/Propel/Generator/Model/PropelTypes.php on lines 174..210

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 347.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              private static $mappingTypeToPDOTypeMap = [
                                  self::CHAR => PDO::PARAM_STR,
                                  self::VARCHAR => PDO::PARAM_STR,
                                  self::LONGVARCHAR => PDO::PARAM_STR,
                                  self::CLOB => PDO::PARAM_STR,
                          Severity: Major
                          Found in src/Propel/Generator/Model/PropelTypes.php and 1 other location - About 2 days to fix
                          src/Propel/Generator/Model/PropelTypes.php on lines 134..166

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 347.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function build has a Cognitive Complexity of 88 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function build()
                              {
                                  $this->validate();
                          
                                  $totalNbFiles = 0;
                          Severity: Minor
                          Found in src/Propel/Generator/Manager/ModelManager.php - About 1 day to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          ModelCriteria has 86 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class ModelCriteria extends BaseModelCriteria
                          {
                              public const FORMAT_STATEMENT = '\Propel\Runtime\Formatter\StatementFormatter';
                              public const FORMAT_ARRAY = '\Propel\Runtime\Formatter\ArrayFormatter';
                              public const FORMAT_OBJECT = '\Propel\Runtime\Formatter\ObjectFormatter';
                          Severity: Major
                          Found in src/Propel/Runtime/ActiveQuery/ModelCriteria.php - About 1 day to fix

                            File Column.php has 686 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            <?php
                            
                            /**
                             * MIT License. This file is part of the Propel package.
                             * For the full copyright and license information, please view the LICENSE
                            Severity: Major
                            Found in src/Propel/Generator/Model/Column.php - About 1 day to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      foreach ($migration->getDownSQL() as $datasource => $sql) {
                                          $connection = $manager->getConnection($datasource);
                              
                                          if ($input->getOption('verbose')) {
                                              $output->writeln(sprintf(
                              Severity: Major
                              Found in src/Propel/Generator/Command/MigrationDownCommand.php and 1 other location - About 1 day to fix
                              src/Propel/Generator/Command/MigrationUpCommand.php on lines 118..179

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 278.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      foreach ($migration->getUpSQL() as $datasource => $sql) {
                                          $connection = $manager->getConnection($datasource);
                              
                                          if ($input->getOption('verbose')) {
                                              $output->writeln(sprintf(
                              Severity: Major
                              Found in src/Propel/Generator/Command/MigrationUpCommand.php and 1 other location - About 1 day to fix
                              src/Propel/Generator/Command/MigrationDownCommand.php on lines 115..172

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 278.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              DefaultPlatform has 77 functions (exceeds 20 allowed). Consider refactoring.
                              Open

                              class DefaultPlatform implements PlatformInterface
                              {
                                  /**
                                   * Mapping from Propel types to Domain objects.
                                   *
                              Severity: Major
                              Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 1 day to fix
                                Severity
                                Category
                                Status
                                Source
                                Language