File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
Very high overall complexity: 675
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
Very high overall complexity: 390
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
Very high overall complexity: 267
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
Identical code found in 1 other location
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical code found in 1 other location
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
High overall complexity: 237
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
High overall complexity: 180
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
High overall complexity: 171
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
Identical code found in 3 other locations
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical code found in 3 other locations
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical code found in 3 other locations
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical code found in 3 other locations
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
High overall complexity: 142
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
High overall complexity: 138
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
High overall complexity: 135
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
Similar code found in 1 other location
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar code found in 1 other location
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Very complex method in createSelectSql
public function createSelectSql(&$params)
{
$adapter = Propel::getServiceContainer()->getAdapter($this->getDbName());
$dbMap = Propel::getServiceContainer()->getDatabaseMap($this->getDbName());
- Read upRead up
Long or complex methods can make code harder to understand. In most circumstances, methods are best as a small chunk of code (the "how") with a clear, understandable name (the "what"). Long methods can also lead to duplication, as it's harder to reuse logic that is tightly coupled to surrounding code.
Refactorings
- Extract Method
- Replace Temp With Query
- Replace Conditional with Polymorphism
- Replace Method with Method Object
- Decompose Conditional
- Preserve Whole Object
- Introduce Parameter Object
Read More
- Long Method on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler, Long Method, p76
- Smalltalk Best Practice Patterns by Kent Beck, Composed Method, p21
Very complex method in startElement
public function startElement($parser, $name, $attributes)
{
$parentTag = $this->peekCurrentSchemaTag();
if (false === $parentTag) {
switch ($name) {- Read upRead up
Long or complex methods can make code harder to understand. In most circumstances, methods are best as a small chunk of code (the "how") with a clear, understandable name (the "what"). Long methods can also lead to duplication, as it's harder to reuse logic that is tightly coupled to surrounding code.
Refactorings
- Extract Method
- Replace Temp With Query
- Replace Conditional with Polymorphism
- Replace Method with Method Object
- Decompose Conditional
- Preserve Whole Object
- Introduce Parameter Object
Read More
- Long Method on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler, Long Method, p76
- Smalltalk Best Practice Patterns by Kent Beck, Composed Method, p21
High overall complexity: 127
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
File is too long
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Exclude checks
Identical code found in 1 other location
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical code found in 1 other location
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical code found in 2 other locations
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical code found in 2 other locations
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical code found in 2 other locations
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
High overall complexity: 118
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
High overall complexity: 115
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
Identical code found in 1 other location
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical code found in 1 other location
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
High overall complexity: 111
<?php
/**
* This file is part of the Propel package.
* For the full copyright and license information, please view the LICENSE- Read upRead up
When classes take on too many responsibilities, they grow. A large number of instance variables or methods can make a class hard to understand. Large classes tend to have lower cohesion and higher churn.
Often large classes have methods that do not operate on all of the class state. Identifying the groups of data that are used together can point to seams to split out additional collaborator classes or value objects.
Another trick is to look for repeated prefixes or suffixes in method and variable names, or repeated parameter names, and use them to guide extractions.
Refactorings
Further Reading
- Single Responsibility Principle
- Large Class on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Large Class, p78
Class Table contains too many public methods
class Table extends ScopedMappingModel implements IdMethod
{
use BehaviorableTrait;
/**- Exclude checks