propelorm/Propel2

View on GitHub
src/Propel/Generator/Model/Diff/TableComparator.php

Summary

Maintainability
D
2 days
Test Coverage

Function compareColumns has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function compareColumns($caseInsensitive = false)
    {
        $fromTableColumns = $this->getFromTable()->getColumns();
        $toTableColumns = $this->getToTable()->getColumns();
        $columnDifferences = 0;
Severity: Minor
Found in src/Propel/Generator/Model/Diff/TableComparator.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compareForeignKeys has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function compareForeignKeys($caseInsensitive = false)
    {
        $fkDifferences = 0;
        $fromTableFks = $this->getFromTable()->getForeignKeys();
        $toTableFks = $this->getToTable()->getForeignKeys();
Severity: Minor
Found in src/Propel/Generator/Model/Diff/TableComparator.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function comparePrimaryKeys has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function comparePrimaryKeys($caseInsensitive = false)
    {
        $pkDifferences = 0;
        $fromTablePk = $this->getFromTable()->getPrimaryKey();
        $toTablePk = $this->getToTable()->getPrimaryKey();
Severity: Minor
Found in src/Propel/Generator/Model/Diff/TableComparator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function compareIndices has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function compareIndices($caseInsensitive = false)
    {
        $indexDifferences = 0;
        $fromTableIndices = array_merge($this->getFromTable()->getIndices(), $this->getFromTable()->getUnices());
        $toTableIndices = array_merge($this->getToTable()->getIndices(), $this->getToTable()->getUnices());
Severity: Minor
Found in src/Propel/Generator/Model/Diff/TableComparator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compareColumns has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function compareColumns($caseInsensitive = false)
    {
        $fromTableColumns = $this->getFromTable()->getColumns();
        $toTableColumns = $this->getToTable()->getColumns();
        $columnDifferences = 0;
Severity: Minor
Found in src/Propel/Generator/Model/Diff/TableComparator.php - About 1 hr to fix

    Method compareForeignKeys has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function compareForeignKeys($caseInsensitive = false)
        {
            $fkDifferences = 0;
            $fromTableFks = $this->getFromTable()->getForeignKeys();
            $toTableFks = $this->getToTable()->getForeignKeys();
    Severity: Minor
    Found in src/Propel/Generator/Model/Diff/TableComparator.php - About 1 hr to fix

      Method compareIndices has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function compareIndices($caseInsensitive = false)
          {
              $indexDifferences = 0;
              $fromTableIndices = array_merge($this->getFromTable()->getIndices(), $this->getFromTable()->getUnices());
              $toTableIndices = array_merge($this->getToTable()->getIndices(), $this->getToTable()->getUnices());
      Severity: Minor
      Found in src/Propel/Generator/Model/Diff/TableComparator.php - About 1 hr to fix

        Method comparePrimaryKeys has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function comparePrimaryKeys($caseInsensitive = false)
            {
                $pkDifferences = 0;
                $fromTablePk = $this->getFromTable()->getPrimaryKey();
                $toTablePk = $this->getToTable()->getPrimaryKey();
        Severity: Minor
        Found in src/Propel/Generator/Model/Diff/TableComparator.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  foreach ($this->tableDiff->getAddedPkColumns() as $addedColumnName => $addedColumn) {
                      foreach ($this->tableDiff->getRemovedPkColumns() as $removedColumnName => $removedColumn) {
                          if (!ColumnComparator::computeDiff($addedColumn, $removedColumn, $caseInsensitive)) {
                              // no difference except the name, that's probably a renaming
                              $this->tableDiff->addRenamedPkColumn($removedColumn, $addedColumn);
          Severity: Minor
          Found in src/Propel/Generator/Model/Diff/TableComparator.php and 1 other location - About 45 mins to fix
          src/Propel/Generator/Model/Diff/TableComparator.php on lines 157..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  foreach ($this->tableDiff->getAddedColumns() as $addedColumnName => $addedColumn) {
                      foreach ($this->tableDiff->getRemovedColumns() as $removedColumnName => $removedColumn) {
                          if (!ColumnComparator::computeDiff($addedColumn, $removedColumn, $caseInsensitive)) {
                              // no difference except the name, that's probably a renaming
                              $this->tableDiff->addRenamedColumn($removedColumn, $addedColumn);
          Severity: Minor
          Found in src/Propel/Generator/Model/Diff/TableComparator.php and 1 other location - About 45 mins to fix
          src/Propel/Generator/Model/Diff/TableComparator.php on lines 208..220

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if ($sameName) {
                              if (false === IndexComparator::computeDiff($fromTableIndex, $toTableIndex, $caseInsensitive)) {
                                  //no changes
                                  unset($fromTableIndices[$fromTableIndexPos]);
                                  unset($toTableIndices[$toTableIndexPos]);
          Severity: Minor
          Found in src/Propel/Generator/Model/Diff/TableComparator.php and 1 other location - About 40 mins to fix
          src/Propel/Generator/Model/Diff/TableComparator.php on lines 294..305

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if ($sameName && !$toTableFk->isPolymorphic()) {
                              if (false === ForeignKeyComparator::computeDiff($fromTableFk, $toTableFk, $caseInsensitive)) {
                                  unset($fromTableFks[$fromTableFkPos]);
                                  unset($toTableFks[$toTableFkPos]);
                              } else {
          Severity: Minor
          Found in src/Propel/Generator/Model/Diff/TableComparator.php and 1 other location - About 40 mins to fix
          src/Propel/Generator/Model/Diff/TableComparator.php on lines 245..257

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 78.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status