propelorm/Propel2

View on GitHub
src/Propel/Generator/Platform/DefaultPlatform.php

Summary

Maintainability
F
5 days
Test Coverage

File DefaultPlatform.php has 823 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
Severity: Major
Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 1 day to fix

    DefaultPlatform has 77 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DefaultPlatform implements PlatformInterface
    {
    
        /**
         * Mapping from Propel types to Domain objects.
    Severity: Major
    Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 1 day to fix

      Function getModifyTableDDL has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getModifyTableDDL(TableDiff $tableDiff)
          {
              $ret = '';
      
              $toTable = $tableDiff->getToTable();
      Severity: Minor
      Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getModifyTableDDL has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getModifyTableDDL(TableDiff $tableDiff)
          {
              $ret = '';
      
              $toTable = $tableDiff->getToTable();
      Severity: Major
      Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 3 hrs to fix

        Function getColumnDefaultValueDDL has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getColumnDefaultValueDDL(Column $col)
            {
                $default = '';
                $defaultValue = $col->getDefaultValue();
                if (null !== $defaultValue) {
        Severity: Minor
        Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function normalizeTable has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function normalizeTable(Table $table)
            {
                if ($table->hasForeignKeys()) {
                    foreach ($table->getForeignKeys() as $fk) {
                        if ($fk->getForeignTable() && !$fk->getForeignTable()->isUnique($fk->getForeignColumnObjects())) {
        Severity: Minor
        Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSequenceName has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getSequenceName(Table $table)
            {
                static $longNamesMap = [];
                $result = null;
                if (IdMethod::NATIVE === $table->getIdMethod()) {
        Severity: Minor
        Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getColumnDefaultValueDDL has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getColumnDefaultValueDDL(Column $col)
            {
                $default = '';
                $defaultValue = $col->getDefaultValue();
                if (null !== $defaultValue) {
        Severity: Minor
        Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 1 hr to fix

          Method getIdentifierPhp has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getIdentifierPhp($columnValueMutator, $connectionVariableName = '$con', $sequenceName = '', $tab = "            ", $phpType = null)
          Severity: Minor
          Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 35 mins to fix

            Function getColumnDDL has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getColumnDDL(Column $col)
                {
                    $domain = $col->getDomain();
            
                    $ddl = [$this->quoteIdentifier($col->getName())];
            Severity: Minor
            Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getModifyDatabaseDDL has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getModifyDatabaseDDL(DatabaseDiff $databaseDiff)
                {
                    $ret = '';
                    foreach ($databaseDiff->getRemovedTables() as $table) {
                        $ret .= $this->getDropTableDDL($table);
            Severity: Minor
            Found in src/Propel/Generator/Platform/DefaultPlatform.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function getModifyTableForeignKeysDDL(TableDiff $tableDiff)
                {
                    $ret = '';
            
                    foreach ($tableDiff->getRemovedFks() as $fk) {
            Severity: Major
            Found in src/Propel/Generator/Platform/DefaultPlatform.php and 1 other location - About 1 hr to fix
            src/Propel/Generator/Platform/DefaultPlatform.php on lines 918..937

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 98.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function getModifyTableIndicesDDL(TableDiff $tableDiff)
                {
                    $ret = '';
            
                    foreach ($tableDiff->getRemovedIndices() as $index) {
            Severity: Major
            Found in src/Propel/Generator/Platform/DefaultPlatform.php and 1 other location - About 1 hr to fix
            src/Propel/Generator/Platform/DefaultPlatform.php on lines 945..964

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 98.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status