propelorm/Propel2

View on GitHub
src/Propel/Generator/Reverse/SqliteSchemaParser.php

Summary

Maintainability
F
3 days
Test Coverage

Function addColumns has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    protected function addColumns(Table $table)
    {
        $tableName = $table->getName();

//        var_dump("PRAGMA table_info('$tableName') //");
Severity: Minor
Found in src/Propel/Generator/Reverse/SqliteSchemaParser.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseTables has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseTables(Database $database, Table $filterTable = null)
    {
        $sql = "
        SELECT name
        FROM sqlite_master
Severity: Minor
Found in src/Propel/Generator/Reverse/SqliteSchemaParser.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addColumns has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addColumns(Table $table)
    {
        $tableName = $table->getName();

//        var_dump("PRAGMA table_info('$tableName') //");
Severity: Major
Found in src/Propel/Generator/Reverse/SqliteSchemaParser.php - About 2 hrs to fix

    Function addForeignKeys has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function addForeignKeys(Table $table)
        {
            $database = $table->getDatabase();
    
            $stmt = $this->dbh->query('PRAGMA foreign_key_list("' . $table->getName() . '")');
    Severity: Minor
    Found in src/Propel/Generator/Reverse/SqliteSchemaParser.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function addIndexes has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function addIndexes(Table $table)
        {
            $stmt = $this->dbh->query('PRAGMA index_list("' . $table->getName() . '")');
    
            while ($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
    Severity: Minor
    Found in src/Propel/Generator/Reverse/SqliteSchemaParser.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parseTables has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function parseTables(Database $database, Table $filterTable = null)
        {
            $sql = "
            SELECT name
            FROM sqlite_master
    Severity: Minor
    Found in src/Propel/Generator/Reverse/SqliteSchemaParser.php - About 1 hr to fix

      Method addForeignKeys has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function addForeignKeys(Table $table)
          {
              $database = $table->getDatabase();
      
              $stmt = $this->dbh->query('PRAGMA foreign_key_list("' . $table->getName() . '")');
      Severity: Minor
      Found in src/Propel/Generator/Reverse/SqliteSchemaParser.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private static $sqliteTypeMap = [
                'tinyint'    => PropelTypes::TINYINT,
                'smallint'   => PropelTypes::SMALLINT,
                'mediumint'  => PropelTypes::SMALLINT,
                'int'        => PropelTypes::INTEGER,
        Severity: Major
        Found in src/Propel/Generator/Reverse/SqliteSchemaParser.php and 1 other location - About 1 day to fix
        src/Propel/Generator/Reverse/MysqlSchemaParser.php on lines 38..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 238.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status