Sign upLogin

propelorm/Propel2

View on GitHub
Star
src/Propel/Runtime/ActiveQuery/Join.php

Summary

Maintainability
D
2 days
Test Coverage

Join has 48 functions (exceeds 20 allowed). Consider refactoring.
Open

class Join
{
    // default comparison type
    /**
     * @var string
Severity: Minor
Found in src/Propel/Runtime/ActiveQuery/Join.php - About 6 hrs to fix

    File Join.php has 373 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * MIT License. This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
    Severity: Minor
    Found in src/Propel/Runtime/ActiveQuery/Join.php - About 4 hrs to fix

      Method buildJoinCondition has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function buildJoinCondition(Criteria $c): void
    {
        /** @var \Propel\Runtime\ActiveQuery\Criterion\AbstractCriterion|null $joinCondition */
        $joinCondition = null;
        for ($i = 0; $i < $this->count; $i++) {
      Severity: Minor
      Found in src/Propel/Runtime/ActiveQuery/Join.php - About 1 hr to fix

        Function getClause has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getClause(array &$params): string
    {
        if ($this->joinCondition === null) {
            $conditions = [];
            for ($i = 0; $i < $this->count; $i++) {
        Severity: Minor
        Found in src/Propel/Runtime/ActiveQuery/Join.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __construct($leftColumn = null, $rightColumn = null, ?string $joinType = null)
    {
        if ($leftColumn !== null && $rightColumn !== null) {
            if (is_array($leftColumn) && is_array($rightColumn)) {
                // join with multiple conditions
        Severity: Minor
        Found in src/Propel/Runtime/ActiveQuery/Join.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getClause has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getClause(array &$params): string
    {
        if ($this->joinCondition === null) {
            $conditions = [];
            for ($i = 0; $i < $this->count; $i++) {
        Severity: Minor
        Found in src/Propel/Runtime/ActiveQuery/Join.php - About 1 hr to fix

          Method addExplicitCondition has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  string $leftTableName,
        string $leftColumnName,
        ?string $leftTableAlias = null,
        ?string $rightTableName = null,
        ?string $rightColumnName = null,
          Severity: Major
          Found in src/Propel/Runtime/ActiveQuery/Join.php - About 50 mins to fix

            Function buildJoinCondition has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function buildJoinCondition(Criteria $c): void
    {
        /** @var \Propel\Runtime\ActiveQuery\Criterion\AbstractCriterion|null $joinCondition */
        $joinCondition = null;
        for ($i = 0; $i < $this->count; $i++) {
            Severity: Minor
            Found in src/Propel/Runtime/ActiveQuery/Join.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method addForeignValueCondition has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    string $rightTableName,
        string $rightColumnName,
        ?string $rightTableAlias,
        $rightColumnValue,
        string $operator = self::EQUAL
            Severity: Minor
            Found in src/Propel/Runtime/ActiveQuery/Join.php - About 35 mins to fix

              Method addLocalValueCondition has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      string $leftTableName,
        string $leftColumnName,
        ?string $leftTableAlias,
        $leftColumnValue,
        string $operator = self::EQUAL
              Severity: Minor
              Found in src/Propel/Runtime/ActiveQuery/Join.php - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function addLocalValueCondition(
        string $leftTableName,
        string $leftColumnName,
        ?string $leftTableAlias,
        $leftColumnValue,
                Severity: Major
                Found in src/Propel/Runtime/ActiveQuery/Join.php and 1 other location - About 1 hr to fix
                src/Propel/Runtime/ActiveQuery/Join.php on lines 289..304

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 117.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function addForeignValueCondition(
        string $rightTableName,
        string $rightColumnName,
        ?string $rightTableAlias,
        $rightColumnValue,
                Severity: Major
                Found in src/Propel/Runtime/ActiveQuery/Join.php and 1 other location - About 1 hr to fix
                src/Propel/Runtime/ActiveQuery/Join.php on lines 263..278

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 117.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status