Sign upLogin

publiclab/image-sequencer

View on GitHub
Star

Showing 267 of 267 total issues

Avoid deeply nested control flow statements.
Open

            if (pixels.data[curr + channels - 1] === 0) {
              const prev = prevIndex + j * channels;
  
              for (let k = 0; k < channels; ++k) {
                pixels.data[curr + k] = pixels.data[prev + k];
Severity: Major
Found in src/modules/_nomodule/PixelManipulation.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          if (!((grads[x][y] >= grads[x + 1][y]) && (grads[x][y] >= grads[x - 1][y]))) {
            pixelsToBeSupressed.push([x, y]);
          }
Severity: Major
Found in src/modules/EdgeDetect/EdgeUtils.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          if (!((grads[x][y] >= grads[x + 1][y + 1]) && (grads[x][y] >= grads[x - 1][y - 1]))){
            pixelsToBeSupressed.push([x, y]);
          }
Severity: Major
Found in src/modules/EdgeDetect/EdgeUtils.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

            if (k >= w && l >= h && ((k - w) >= (l - h))) {
              continue;
            }
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Function changePixel has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

          function changePixel(r2, g2, b2, a2, x, y) {
Severity: Minor
Found in src/modules/Mask/Module.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          for (var l = 0; l < (h + options.Y_value); l++) {
            if (l + (k * (options.Y_value / Math.abs(options.X_value))) - (options.Y_value + h) > 0 && l >= h) {
              continue;
            }
            let val = 255 - ((k / Math.abs(options.X_value)) * 255);
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

            if (inputDesc.type.toLowerCase() == 'range') {
              html +=
                '"min="' +
                inputDesc.min +
                '"max="' +
Severity: Major
Found in examples/lib/defaultHtmlStepUi.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          for (var l = h; l < (h + options.Y_value); l++) {
            let val = ((l - h) / options.Y_value * 255);
            pixelSetter(k, l, [val, val, val, 255], newPixels);
          }
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

        for (var k = w; k < (w + options.X_value); k++) {
          for (var l = 0; l < (h + Math.abs(options.Y_value)); l++) {
            let val = (((k - w) / options.X_value) * 255);
            pixelSetter(k, l, [val, val, val, 255], newPixels);
          }
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Function changePixel has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      function changePixel(r1, g1, b1, a1, x, y) {
Severity: Minor
Found in src/modules/Overlay/Module.js - About 45 mins to fix

Function DoNothing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function DoNothing(options, UI) {

  var output;

  var gl = require('fisheyegl');
Severity: Minor
Found in src/modules/FisheyeGl/Module.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Threshold has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function Threshold(pixels, options, histData) {
  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
   
  type = options.threshold || defaults.threshold;
  threshold = parseInt(options.input) || defaults.input;
Severity: Minor
Found in src/modules/Threshold/Threshold.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

            for (let c = 0; c < channels; c++) {
              frames[f].set(x, y, c, pixels.get(f, x, y, c));
            }
Severity: Major
Found in src/modules/_nomodule/PixelManipulation.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          if (!((grads[x][y] >= grads[x][y + 1]) && (grads[x][y] >= grads[x][y - 1]))) {
            pixelsToBeSupressed.push([x, y]);
          }
Severity: Major
Found in src/modules/EdgeDetect/EdgeUtils.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

        for (var k = 0; k < (w + options.X_value); k++) {
          for (var l = 0; l < Math.abs(options.Y_value); l++) {
            if (l >= ((options.X_value / Math.abs(options.Y_value)) * (w + options.X_value - k)) && k >= w) {
              continue;
            }
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Function copyPixel has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function copyPixel(x1, y1, x2, y2, finalPix, initPix) {
Severity: Minor
Found in src/modules/Rotate/Rotate.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          for (let j = 0; j < jMax && j < h; j++) {
            let x = i + Math.abs(options.X_value), y = j;
            pixelSetter(x, y, [pixels.get(i, j, 0), pixels.get(i, j, 1), pixels.get(i, j, 2), pixels.get(i, j, 3)], newPixels);
          }
Severity: Major
Found in src/modules/Shadow/Module.js - About 45 mins to fix

Function categorizeAngle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

function categorizeAngle(angle){
  const pi = Math.PI;
  angle = angle > 0 ? angle : pi - Math.abs(angle); // Diagonally flip the angle if it is negative (since edge remains the same)

  if (angle <= pi / 8 || angle > 7 * pi / 8) return 1;
Severity: Minor
Found in src/modules/EdgeDetect/EdgeUtils.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

          if (!((grads[x][y] >= grads[x + 1][y - 1]) && (grads[x][y] >= grads[x - 1][y + 1]))) {
            pixelsToBeSupressed.push([x, y]);
          }
Severity: Major
Found in src/modules/EdgeDetect/EdgeUtils.js - About 45 mins to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          function output(image, datauri, mimetype, wasmSuccess) {
            step.output = {
              src: datauri,
              format: mimetype,
              wasmSuccess,
Severity: Minor
Found in src/modules/Mask/Module.js and 1 other location - About 45 mins to fix
src/modules/Blend/Module.js on lines 108..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language