Sign upLogin

publiclab/image-sequencer

View on GitHub
Star

Showing 267 of 267 total issues

Function Dither has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Dither(pixels, type) {
  type = type;
  let bayerThresholdMap = [
    [15, 135, 45, 165],
    [195, 75, 225, 105],
Severity: Major
Found in src/modules/Dither/Dither.js - About 2 hrs to fix

Function exports has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(pixels){
  var canvas = document.createElement('canvas');
  canvas.width = pixels.shape[0];
  canvas.height = pixels.shape[1];
  var ctx = canvas.getContext('2d');
Severity: Major
Found in src/modules/BlobAnalysis/BlobAnalysis.js - About 2 hrs to fix

File demo.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var defaultHtmlSequencerUi = require('./lib/defaultHtmlSequencerUi.js'),
  setupCache = require('./lib/cache.js'),
  intermediateHtmlStepUi = require('./lib/intermediateHtmlStepUi.js'),
  DefaultHtmlStepUi = require('./lib/defaultHtmlStepUi.js'),
  urlHash = require('./lib/urlHash.js'),
Severity: Minor
Found in examples/demo.js - About 2 hrs to fix

Function Average has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Average(options, UI) {

  var output;

  options.step.metadata = options.step.metadata || {};
Severity: Major
Found in src/modules/Average/Module.js - About 2 hrs to fix

Function onload has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    image.onload = function() {

      var texture = canvas.texture(image);

      // var bbox1 = {
Severity: Major
Found in src/modules/WebglDistort/Module.js - About 2 hrs to fix

Function draw has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function draw(input, callback, progressObj) {
    progressObj.stop(true);
    progressObj.overrideFlag = true;

    var step = this;
Severity: Minor
Found in src/modules/Mask/Module.js - About 2 hrs to fix

Function draw has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function draw(input, callback, progressObj) {

    options.temperature = options.temperature || defaults.temperature;
    options.temperature = (options.temperature > 40000) ? 40000 : options.temperature;
    options.temperature = (options.temperature < 0) ? 0 : options.temperature;
Severity: Minor
Found in src/modules/ColorTemperature/Module.js - About 1 hr to fix

Function AddQR has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function AddQR(options, UI) {

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  var output;
  getPixels = require('get-pixels');
Severity: Minor
Found in src/modules/AddQR/Module.js - About 1 hr to fix

Function InsertStep has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function InsertStep(ref, index, name, o) {
  if (ref.sequences[name]) {
    return ref.importJSON(ref.sequences[name]);
  }
Severity: Minor
Found in src/InsertStep.js - About 1 hr to fix

Function ColorHalftone has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function ColorHalftone(options, UI) {

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));

  var output;
Severity: Minor
Found in src/modules/ColorHalftone/Module.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Gradient has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Gradient(options, UI) {

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  options.gradientType = options.gradientType || defaults.gradientType;
Severity: Minor
Found in src/modules/Gradient/Module.js - About 1 hr to fix

Function ReplaceImage has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function ReplaceImage(ref, selector, steps, options) {
  if(!ref.options.inBrowser) return false; // This isn't for Node.js
  var tempSequencer = ImageSequencer({ui: false});
  var this_ = ref;
  if (window.hasOwnProperty('$')) var input = $(selector);
Severity: Minor
Found in src/ReplaceImage.js - About 1 hr to fix

Function ConstrainedCrop has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function ConstrainedCrop(options, UI) {

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  var output;
Severity: Minor
Found in src/modules/ConstrainedCrop/Module.js - About 1 hr to fix

Function Contrast has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Contrast(options, UI) {

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  options.contrast = options.contrast || defaults.contrast;
  var output;
Severity: Minor
Found in src/modules/Contrast/Module.js - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  getWidth: function(callback) {
    let img = new Image();
    img.onload = function() {
      callback(img.width);
    };
Severity: Major
Found in src/util/getStep.js and 1 other location - About 1 hr to fix
src/util/getStep.js on lines 34..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  getHeight: function(callback) {
    let img = new Image();
    img.onload = function() {
      callback(img.height);
    };
Severity: Major
Found in src/util/getStep.js and 1 other location - About 1 hr to fix
src/util/getStep.js on lines 42..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function DoNothing has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function DoNothing(options, UI) {

  var output;

  var gl = require('fisheyegl');
Severity: Minor
Found in src/modules/FisheyeGl/Module.js - About 1 hr to fix

Function canvasResize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function canvasResize(options, UI) {

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));
  const pixelSetter = require('../../util/pixelSetter.js');
Severity: Minor
Found in src/modules/CanvasResize/Module.js - About 1 hr to fix

Function convolve has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const convolve = (arrays, kernel, options = {}) => {
  const pipeMode = options.pipeMode || false,
    mode = options.mode || 'gpu';

  const gpu = new GPU(mode != 'gpu' ? {mode} : {});
Severity: Minor
Found in src/modules/_nomodule/gpuUtils.js - About 1 hr to fix

Function Balance has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Balance(options, UI) {

  var defaults = require('./../../util/getDefaults.js')(require('./info.json'));

  options.red = options.red || defaults.red;
Severity: Minor
Found in src/modules/WhiteBalance/Module.js - About 1 hr to fix
Severity
Category
Status
Source
Language