Sign upLogin

puppetlabs/facter-ng

View on GitHub
Star
lib/framework/core/cache_manager.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method resolve_fact has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def resolve_fact(searched_fact)
      group_name =  if searched_fact.file
                      searched_fact.name
                    else
                      @fact_groups.get_fact_group(searched_fact.name)
Severity: Minor
Found in lib/framework/core/cache_manager.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cache_fact has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def cache_fact(fact)
      group_name = if fact.file
                     File.basename(fact.file)
                   else
                     @fact_groups.get_fact_group(fact.name)
Severity: Minor
Found in lib/framework/core/cache_manager.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method write_cache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def write_cache
      unless File.directory?(@cache_dir)
        require 'fileutils'
        FileUtils.mkdir_p(@cache_dir)
      end
Severity: Minor
Found in lib/framework/core/cache_manager.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status