q9f/ruby-eth

View on GitHub
lib/eth/open_ssl.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method recover_public_key_from_signature has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def recover_public_key_from_signature(message_hash, signature, rec_id, is_compressed)
        return nil if rec_id < 0 or signature.bytesize != 65
        init_ffi_ssl

        signature = FFI::MemoryPointer.from_string(signature)
Severity: Minor
Found in lib/eth/open_ssl.rb - About 1 hr to fix

    Method sign_compact has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def sign_compact(hash, private_key, public_key_hex)
            private_key = [private_key].pack("H*") if private_key.bytesize >= 64
            pubkey_compressed = false
    
            init_ffi_ssl
    Severity: Minor
    Found in lib/eth/open_ssl.rb - About 1 hr to fix

      Method sign_compact has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def sign_compact(hash, private_key, public_key_hex)
              private_key = [private_key].pack("H*") if private_key.bytesize >= 64
              pubkey_compressed = false
      
              init_ffi_ssl
      Severity: Minor
      Found in lib/eth/open_ssl.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status