Sign upLogin

qbeon/webwire-go

View on GitHub
Star

Showing 32 of 32 total issues

Function WriteMsgRequest has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
Open

func WriteMsgRequest(
    writer io.WriteCloser,
    identifier []byte,
    name []byte,
    payloadEncoding pld.Encoding,
Severity: Minor
Found in message/writeMsgRequest.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function WriteMsgSignal has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
Open

func WriteMsgSignal(
    writer io.WriteCloser,
    name []byte,
    payloadEncoding pld.Encoding,
    payloadData []byte,
Severity: Minor
Found in message/writeMsgSignal.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function WriteMsgReplyError has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func WriteMsgReplyError(
    writer io.WriteCloser,
    requestIdent []byte,
    code,
    message []byte,
Severity: Minor
Found in message/writeMsgErrorReply.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function WriteMsgRequest has 91 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func WriteMsgRequest(
    writer io.WriteCloser,
    identifier []byte,
    name []byte,
    payloadEncoding pld.Encoding,
Severity: Major
Found in message/writeMsgRequest.go - About 2 hrs to fix

    Method server.failMsg has 84 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (srv *server) failMsg(
    con *connection,
    msg *message.Message,
    reqErr error,
) {
    Severity: Major
    Found in failMsg.go - About 2 hrs to fix

      Function WriteMsgSignal has 78 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func WriteMsgSignal(
    writer io.WriteCloser,
    name []byte,
    payloadEncoding pld.Encoding,
    payloadData []byte,
      Severity: Major
      Found in message/writeMsgSignal.go - About 2 hrs to fix

        Method server.handleSessionRestore has 73 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (srv *server) handleSessionRestore(
    con *connection,
    msg *message.Message,
) {
    finalize := func() {
        Severity: Minor
        Found in handleSessionRestore.go - About 1 hr to fix

          Function WriteMsgRequest has 21 return statements (exceeds 4 allowed).
          Open

          func WriteMsgRequest(
    writer io.WriteCloser,
    identifier []byte,
    name []byte,
    payloadEncoding pld.Encoding,
          Severity: Major
          Found in message/writeMsgRequest.go - About 1 hr to fix

            Function NewServer has 66 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func NewServer(
    implementation ServerImplementation,
    opts ServerOptions,
    transport Transport,
) (instance Server, err error) {
            Severity: Minor
            Found in newServer.go - About 1 hr to fix

              Function WriteMsgReplyError has 66 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func WriteMsgReplyError(
    writer io.WriteCloser,
    requestIdent []byte,
    code,
    message []byte,
              Severity: Minor
              Found in message/writeMsgErrorReply.go - About 1 hr to fix

                Function WriteMsgReplyError has 17 return statements (exceeds 4 allowed).
                Open

                func WriteMsgReplyError(
    writer io.WriteCloser,
    requestIdent []byte,
    code,
    message []byte,
                Severity: Major
                Found in message/writeMsgErrorReply.go - About 1 hr to fix

                  Function WriteMsgSignal has 17 return statements (exceeds 4 allowed).
                  Open

                  func WriteMsgSignal(
    writer io.WriteCloser,
    name []byte,
    payloadEncoding pld.Encoding,
    payloadData []byte,
                  Severity: Major
                  Found in message/writeMsgSignal.go - About 1 hr to fix

                    Method Message.parse has 63 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func (msg *Message) parse() (parsedMsgType bool, err error) {
    if msg.MsgBuffer.IsEmpty() {
        return false, nil
    }
    var payloadEncoding pld.Encoding
                    Severity: Minor
                    Found in message/parse.go - About 1 hr to fix

                      Function WriteMsgReply has 11 return statements (exceeds 4 allowed).
                      Open

                      func WriteMsgReply(
    writer io.WriteCloser,
    requestIdentifier []byte,
    payloadEncoding pld.Encoding,
    payloadData []byte,
                      Severity: Major
                      Found in message/writeMsgReply.go - About 1 hr to fix

                        Method server.failMsg has 8 return statements (exceeds 4 allowed).
                        Open

                        func (srv *server) failMsg(
    con *connection,
    msg *message.Message,
    reqErr error,
) {
                        Severity: Major
                        Found in failMsg.go - About 50 mins to fix

                          Function WriteMsgRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              writer io.WriteCloser,
    identifier []byte,
    name []byte,
    payloadEncoding pld.Encoding,
    payloadData []byte,
                          Severity: Minor
                          Found in message/writeMsgRequest.go - About 45 mins to fix

                            Function WriteMsgNamelessRequest has 7 return statements (exceeds 4 allowed).
                            Open

                            func WriteMsgNamelessRequest(
    writer io.WriteCloser,
    reqType byte,
    identifier []byte,
    binaryPayload []byte,
                            Severity: Major
                            Found in message/writeMsgNamelessRequest.go - About 45 mins to fix

                              Function WriteMsgSpecialRequestReply has 7 return statements (exceeds 4 allowed).
                              Open

                              func WriteMsgSpecialRequestReply(
    writer io.WriteCloser,
    reqType byte,
    reqIdent []byte,
) error {
                              Severity: Major
                              Found in message/writeMsgSpecialRequestReply.go - About 45 mins to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                func CalcMsgLenRequest(
    name []byte,
    encoding pld.Encoding,
    payload []byte,
) int {
                                Severity: Minor
                                Found in message/calcMsgLen.go and 1 other location - About 45 mins to fix
                                message/calcMsgLen.go on lines 7..16

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 113.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                func CalcMsgLenSignal(
    name []byte,
    encoding pld.Encoding,
    payload []byte,
) int {
                                Severity: Minor
                                Found in message/calcMsgLen.go and 1 other location - About 45 mins to fix
                                message/calcMsgLen.go on lines 20..29

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 113.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language