Sign upLogin

qbeon/webwire-go

View on GitHub
Star

Showing 32 of 32 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package message

import (
    "fmt"
    "io"
Severity: Minor
Found in message/writeMsgSessionClosed.go and 1 other location - About 40 mins to fix
message/writeMsgHeartbeat.go on lines 1..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package message

import (
    "fmt"
    "io"
Severity: Minor
Found in message/writeMsgHeartbeat.go and 1 other location - About 40 mins to fix
message/writeMsgSessionClosed.go on lines 1..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function NewServer has 6 return statements (exceeds 4 allowed).
Open

func NewServer(
    implementation ServerImplementation,
    opts ServerOptions,
    transport Transport,
) (instance Server, err error) {
Severity: Major
Found in newServer.go - About 40 mins to fix

    Function WriteMsgSignal has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        writer io.WriteCloser,
    name []byte,
    payloadEncoding pld.Encoding,
    payloadData []byte,
    safeMode bool,
    Severity: Minor
    Found in message/writeMsgSignal.go - About 35 mins to fix

      Method Socket.Read has 5 return statements (exceeds 4 allowed).
      Open

      func (sock *Socket) Read(
    msg *message.Message,
    deadline time.Time,
) (err wwr.ErrSockRead) {
    // Set reader lock to ensure there's only one concurrent reader
      Severity: Major
      Found in transport/memchan/socket.go - About 35 mins to fix

        Method connection.CreateSession has 5 return statements (exceeds 4 allowed).
        Open

        func (con *connection) CreateSession(attachment SessionInfo) error {
    if !con.srv.sessionsEnabled {
        return ErrSessionsDisabled{}
    }
        Severity: Major
        Found in connection.go - About 35 mins to fix

          Method Socket.Dial has 5 return statements (exceeds 4 allowed).
          Open

          func (sock *Socket) Dial(deadline time.Time) error {
    if sock.sockType != SocketClient {
        return errors.New("cannot dial on a non-client socket")
    }
          Severity: Major
          Found in transport/memchan/socket.go - About 35 mins to fix

            Method server.handleSessionRestore has 5 return statements (exceeds 4 allowed).
            Open

            func (srv *server) handleSessionRestore(
    con *connection,
    msg *message.Message,
) {
    finalize := func() {
            Severity: Major
            Found in handleSessionRestore.go - About 35 mins to fix

              Method server.writeConfMessage has 5 return statements (exceeds 4 allowed).
              Open

              func (srv *server) writeConfMessage(sock Socket) error {
    writer, err := sock.GetWriter()
    if err != nil {
        return fmt.Errorf(
            "couldn't get writer for configuration message: %s",
              Severity: Major
              Found in handleConnection.go - About 35 mins to fix

                Function WriteMsgNotifySessionCreated has 5 return statements (exceeds 4 allowed).
                Open

                func WriteMsgNotifySessionCreated(
    writer io.WriteCloser,
    sessionInfo []byte,
) error {
    // Write message type flag
                Severity: Major
                Found in message/writeMsgSessionCreated.go - About 35 mins to fix

                  Method DefaultSessionManager.OnSessionLookup has 5 return statements (exceeds 4 allowed).
                  Open

                  func (mng *DefaultSessionManager) OnSessionLookup(key string) (
    SessionLookupResult,
    error,
) {
    path := mng.filePath(key)
                  Severity: Major
                  Found in defaultSessionManager.go - About 35 mins to fix

                    Function WriteMsgReply has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                    Open

                    func WriteMsgReply(
    writer io.WriteCloser,
    requestIdentifier []byte,
    payloadEncoding pld.Encoding,
    payloadData []byte,
                    Severity: Minor
                    Found in message/writeMsgReply.go - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language