Sign upLogin

qcubed/framework

View on GitHub
Star
assets/php/examples/basic_qform/listbox.php

Summary

Maintainability
A
25 mins
Test Coverage

Function Form_Create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function Form_Create() {
        // Define our Label
        $this->lblMessage = new QLabel($this);
        $this->lblMessage->Text = '<None>';
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '37', column '27').
Open

        $this->chkPersons = new QCheckBoxList($this);
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '46', column '56').
Open

        $this->chkPersons->AddAction(new QChangeEvent(), new QServerAction('chkPersons_Change'));
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '21', column '27').
Open

        $this->lstPersons = new QListBox($this);
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '34', column '36').
Open

        $this->lstPersons->AddAction(new QChangeEvent(), new QServerAction('lstPersons_Change'));
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '17', column '27').
Open

        $this->lblMessage = new QLabel($this);
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '46', column '36').
Open

        $this->chkPersons->AddAction(new QChangeEvent(), new QServerAction('chkPersons_Change'));
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '34', column '56').
Open

        $this->lstPersons->AddAction(new QChangeEvent(), new QServerAction('lstPersons_Change'));
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'QQ' in method 'Form_Create'.
Open

        $objPersons = Person::LoadAll(QQ::Clause(QQ::OrderBy(QQN::Person()->LastName, QQN::Person()->FirstName)));
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method lstPersons_Change uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // No one was selected
            $this->lblMessage->Text = '<None>';
        }
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'QQ' in method 'Form_Create'.
Open

        $objPersons = Person::LoadAll(QQ::Clause(QQ::OrderBy(QQN::Person()->LastName, QQN::Person()->FirstName)));
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Person' in method 'Form_Create'.
Open

        $objPersons = Person::LoadAll(QQ::Clause(QQ::OrderBy(QQN::Person()->LastName, QQN::Person()->FirstName)));
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method chkPersons_Change uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // No one was selected
            $this->lblMessage->Text = '<None>';
        }
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$strControlId'.
Open

    protected function lstPersons_Change($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strParameter'.
Open

    protected function chkPersons_Change($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strFormId'.
Open

    protected function chkPersons_Change($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strControlId'.
Open

    protected function chkPersons_Change($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strFormId'.
Open

    protected function lstPersons_Change($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$strParameter'.
Open

    protected function lstPersons_Change($strFormId, $strControlId, $strParameter) {
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method Form_Create is not named in camelCase.
Open

    protected function Form_Create() {
        // Define our Label
        $this->lblMessage = new QLabel($this);
        $this->lblMessage->Text = '<None>';
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method lstPersons_Change is not named in camelCase.
Open

    protected function lstPersons_Change($strFormId, $strControlId, $strParameter) {
        // See if there is something selected
        // Note that in the HTML that gets rendered, the <option> values are arbitrary
        // index numbers.  However, we put in the whole Person object as the QListItem
        // value.  So the SelectedValue property of the QListControl will
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method chkPersons_Change is not named in camelCase.
Open

    protected function chkPersons_Change($strFormId, $strControlId, $strParameter) {
        // In this example, since our values are database ids, we use the ids to lookup the names and display them.

        $names = $this->chkPersons->SelectedNames;
Severity: Minor
Found in assets/php/examples/basic_qform/listbox.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status