qcubed/framework

View on GitHub
includes/codegen/QTypeTable.class.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method __get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function __get($strName) {
            switch ($strName) {
                case 'Name':
                    return $this->strName;
                case 'ClassName':
Severity: Minor
Found in includes/codegen/QTypeTable.class.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                elseif (is_object($mixColValue)) return "QApplication::Translate('" . $mixColValue->_toString() . "')";    // whatever is suitable for the constructor of the object
    Severity: Major
    Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  else return "QApplication::Translate('" . str_replace("'", "\\'", $mixColValue) . "')";
      Severity: Major
      Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return $this->arrExtraPropertyArray;
        Severity: Major
        Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return $this->strExtraFieldNamesArray = QType::Cast($mixValue, QType::ArrayType);
          Severity: Major
          Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return $this->strExtraFieldNamesArray;
            Severity: Major
            Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return $a;
              Severity: Major
              Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                        return $this->objKeyColumn = $mixValue;
                Severity: Major
                Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                          return parent::__get($strName);
                  Severity: Major
                  Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                            return $this->arrExtraPropertyArray = QType::Cast($mixValue, QType::ArrayType);
                    Severity: Major
                    Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                              return $this->objManyToManyReferenceArray = QType::Cast($mixValue, QType::ArrayType);
                      Severity: Major
                      Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return (array) $this->objManyToManyReferenceArray;
                        Severity: Major
                        Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                                  return parent::__set($strName, $mixValue);
                          Severity: Major
                          Found in includes/codegen/QTypeTable.class.php - About 30 mins to fix

                            Function Literal has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                    public static function Literal($mixColValue) {
                                        if (is_null($mixColValue)) return 'null';
                                         elseif (is_integer($mixColValue)) return $mixColValue;
                                        elseif (is_bool($mixColValue)) return ($mixColValue ? 'true' : 'false');
                                        elseif (is_float($mixColValue)) return "(float)$mixColValue";
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            The method __set() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                            Open

                                    public function __set($strName, $mixValue) {
                                        try {
                                            switch ($strName) {
                                                case 'Name':
                                                    return $this->strName = QType::Cast($mixValue, QType::String);
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            CyclomaticComplexity

                            Since: 0.1

                            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                            Example

                            // Cyclomatic Complexity = 11
                            class Foo {
                            1   public function example() {
                            2       if ($a == $b) {
                            3           if ($a1 == $b1) {
                                            fiddle();
                            4           } elseif ($a2 == $b2) {
                                            fiddle();
                                        } else {
                                            fiddle();
                                        }
                            5       } elseif ($c == $d) {
                            6           while ($c == $d) {
                                            fiddle();
                                        }
                            7        } elseif ($e == $f) {
                            8           for ($n = 0; $n < $h; $n++) {
                                            fiddle();
                                        }
                                    } else {
                                        switch ($z) {
                            9               case 1:
                                                fiddle();
                                                break;
                            10              case 2:
                                                fiddle();
                                                break;
                            11              case 3:
                                                fiddle();
                                                break;
                                            default:
                                                fiddle();
                                                break;
                                        }
                                    }
                                }
                            }

                            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                            The method __get() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                            Open

                                    public function __get($strName) {
                                        switch ($strName) {
                                            case 'Name':
                                                return $this->strName;
                                            case 'ClassName':
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            CyclomaticComplexity

                            Since: 0.1

                            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                            Example

                            // Cyclomatic Complexity = 11
                            class Foo {
                            1   public function example() {
                            2       if ($a == $b) {
                            3           if ($a1 == $b1) {
                                            fiddle();
                            4           } elseif ($a2 == $b2) {
                                            fiddle();
                                        } else {
                                            fiddle();
                                        }
                            5       } elseif ($c == $d) {
                            6           while ($c == $d) {
                                            fiddle();
                                        }
                            7        } elseif ($e == $f) {
                            8           for ($n = 0; $n < $h; $n++) {
                                            fiddle();
                                        }
                                    } else {
                                        switch ($z) {
                            9               case 1:
                                                fiddle();
                                                break;
                            10              case 2:
                                                fiddle();
                                                break;
                            11              case 3:
                                                fiddle();
                                                break;
                                            default:
                                                fiddle();
                                                break;
                                        }
                                    }
                                }
                            }

                            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                            Avoid using undefined variables such as '$a' which will lead to PHP notices.
                            Open

                                                return $a;
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            UndefinedVariable

                            Since: 2.8.0

                            Detects when a variable is used that has not been defined before.

                            Example

                            class Foo
                            {
                                private function bar()
                                {
                                    // $message is undefined
                                    echo $message;
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                            Avoid using undefined variables such as '$a' which will lead to PHP notices.
                            Open

                                                $a[] = $this->objKeyColumn;
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            UndefinedVariable

                            Since: 2.8.0

                            Detects when a variable is used that has not been defined before.

                            Example

                            class Foo
                            {
                                private function bar()
                                {
                                    // $message is undefined
                                    echo $message;
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                            Avoid using static access to class 'QType' in method '__set'.
                            Open

                                                    return $this->arrExtraPropertyArray = QType::Cast($mixValue, QType::ArrayType);
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            StaticAccess

                            Since: 1.4.0

                            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                            Example

                            class Foo
                            {
                                public function bar()
                                {
                                    Bar::baz();
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#staticaccess

                            Avoid using static access to class 'QType' in method '__set'.
                            Open

                                                    return $this->objManyToManyReferenceArray = QType::Cast($mixValue, QType::ArrayType);
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            StaticAccess

                            Since: 1.4.0

                            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                            Example

                            class Foo
                            {
                                public function bar()
                                {
                                    Bar::baz();
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#staticaccess

                            Avoid using static access to class 'QType' in method '__set'.
                            Open

                                                    return $this->strName = QType::Cast($mixValue, QType::String);
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            StaticAccess

                            Since: 1.4.0

                            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                            Example

                            class Foo
                            {
                                public function bar()
                                {
                                    Bar::baz();
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#staticaccess

                            Avoid using static access to class 'QType' in method '__set'.
                            Open

                                                    return $this->strClassName= QType::Cast($mixValue, QType::String);
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            StaticAccess

                            Since: 1.4.0

                            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                            Example

                            class Foo
                            {
                                public function bar()
                                {
                                    Bar::baz();
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#staticaccess

                            Avoid using static access to class 'QType' in method '__set'.
                            Open

                                                    return $this->strNameArray = QType::Cast($mixValue, QType::ArrayType);
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            StaticAccess

                            Since: 1.4.0

                            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                            Example

                            class Foo
                            {
                                public function bar()
                                {
                                    Bar::baz();
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#staticaccess

                            Avoid using static access to class 'QType' in method '__set'.
                            Open

                                                    return $this->strExtraFieldNamesArray = QType::Cast($mixValue, QType::ArrayType);
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            StaticAccess

                            Since: 1.4.0

                            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                            Example

                            class Foo
                            {
                                public function bar()
                                {
                                    Bar::baz();
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#staticaccess

                            Avoid using static access to class 'QType' in method '__set'.
                            Open

                                                    return $this->strTokenArray = QType::Cast($mixValue, QType::ArrayType);
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            StaticAccess

                            Since: 1.4.0

                            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                            Example

                            class Foo
                            {
                                public function bar()
                                {
                                    Bar::baz();
                                }
                            }

                            Source https://phpmd.org/rules/cleancode.html#staticaccess

                            Avoid excessively long variable names like $strExtraFieldNamesArray. Keep variable name length under 20.
                            Open

                                    protected $strExtraFieldNamesArray;
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            LongVariable

                            Since: 0.2

                            Detects when a field, formal or local variable is declared with a long name.

                            Example

                            class Something {
                                protected $reallyLongIntName = -3; // VIOLATION - Field
                                public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                    $otherReallyLongName = -5; // VIOLATION - Local
                                    for ($interestingIntIndex = 0; // VIOLATION - For
                                         $interestingIntIndex < 10;
                                         $interestingIntIndex++ ) {
                                    }
                                }
                            }

                            Source https://phpmd.org/rules/naming.html#longvariable

                            Avoid excessively long variable names like $objManyToManyReferenceArray. Keep variable name length under 20.
                            Open

                                    protected $objManyToManyReferenceArray;
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            LongVariable

                            Since: 0.2

                            Detects when a field, formal or local variable is declared with a long name.

                            Example

                            class Something {
                                protected $reallyLongIntName = -3; // VIOLATION - Field
                                public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                    $otherReallyLongName = -5; // VIOLATION - Local
                                    for ($interestingIntIndex = 0; // VIOLATION - For
                                         $interestingIntIndex < 10;
                                         $interestingIntIndex++ ) {
                                    }
                                }
                            }

                            Source https://phpmd.org/rules/naming.html#longvariable

                            Avoid excessively long variable names like $arrExtraPropertyArray. Keep variable name length under 20.
                            Open

                                    protected $arrExtraPropertyArray;
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            LongVariable

                            Since: 0.2

                            Detects when a field, formal or local variable is declared with a long name.

                            Example

                            class Something {
                                protected $reallyLongIntName = -3; // VIOLATION - Field
                                public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                    $otherReallyLongName = -5; // VIOLATION - Local
                                    for ($interestingIntIndex = 0; // VIOLATION - For
                                         $interestingIntIndex < 10;
                                         $interestingIntIndex++ ) {
                                    }
                                }
                            }

                            Source https://phpmd.org/rules/naming.html#longvariable

                            Avoid variables with short names like $a. Configured minimum length is 3.
                            Open

                                                $a[] = $this->objKeyColumn;
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            ShortVariable

                            Since: 0.2

                            Detects when a field, local, or parameter has a very short name.

                            Example

                            class Something {
                                private $q = 15; // VIOLATION - Field
                                public static function main( array $as ) { // VIOLATION - Formal
                                    $r = 20 + $this->q; // VIOLATION - Local
                                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                        $r += $this->q;
                                    }
                                }
                            }

                            Source https://phpmd.org/rules/naming.html#shortvariable

                            The method Literal is not named in camelCase.
                            Open

                                    public static function Literal($mixColValue) {
                                        if (is_null($mixColValue)) return 'null';
                                         elseif (is_integer($mixColValue)) return $mixColValue;
                                        elseif (is_bool($mixColValue)) return ($mixColValue ? 'true' : 'false');
                                        elseif (is_float($mixColValue)) return "(float)$mixColValue";
                            Severity: Minor
                            Found in includes/codegen/QTypeTable.class.php by phpmd

                            CamelCaseMethodName

                            Since: 0.2

                            It is considered best practice to use the camelCase notation to name methods.

                            Example

                            class ClassName {
                                public function get_name() {
                                }
                            }

                            Source

                            There are no issues that match your filters.

                            Category
                            Status