Sign upLogin

quack/quack

View on GitHub
Star
src/ast/expr/LambdaExpr.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method format has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function format(Parser $parser)
    {
        $source = '&';

        switch (count($this->parameters)) {
Severity: Minor
Found in src/ast/expr/LambdaExpr.php - About 1 hr to fix

    Function format has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function format(Parser $parser)
    {
        $source = '&';

        switch (count($this->parameters)) {
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method format uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $source .= 'begin' . PHP_EOL;
            $source .= $this->body->format($parser);
            $source .= $parser->indent();
            $source .= 'end';
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method format uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                    } else {
                    $source .= $this->parameters[0]->name;
                }
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'injectScope'.
    Open

                    throw new ScopeError(Localization::message('SCO010', [$param->name]));
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    TODO found
    Open

            // TODO: Must implement return for blocks
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by fixme

    The property $has_brackets is not named in camelCase.
    Open

    class LambdaExpr extends Expr
{
    public $parameters;
    public $kind;
    public $body;
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    The parameter $parent_scope is not named in camelCase.
    Open

        public function injectScope($parent_scope)
    {
        $this->scope = new Scope($parent_scope);
        foreach ($this->parameters as $param) {
            if ($this->scope->hasLocal($param->name)) {
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The property $argument_types is not named in camelCase.
    Open

    class LambdaExpr extends Expr
{
    public $parameters;
    public $kind;
    public $body;
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    The parameter $has_brackets is not named in camelCase.
    Open

        public function __construct($parameters, $kind, $body, $has_brackets)
    {
        $this->parameters = $parameters;
        $this->kind = $kind;
        $this->body = $body;
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The variable $param_type is not named in camelCase.
    Open

        public function injectScope($parent_scope)
    {
        $this->scope = new Scope($parent_scope);
        foreach ($this->parameters as $param) {
            if ($this->scope->hasLocal($param->name)) {
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $param_type is not named in camelCase.
    Open

        public function injectScope($parent_scope)
    {
        $this->scope = new Scope($parent_scope);
        foreach ($this->parameters as $param) {
            if ($this->scope->hasLocal($param->name)) {
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $has_brackets is not named in camelCase.
    Open

        public function __construct($parameters, $kind, $body, $has_brackets)
    {
        $this->parameters = $parameters;
        $this->kind = $kind;
        $this->body = $body;
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $param_type is not named in camelCase.
    Open

        public function injectScope($parent_scope)
    {
        $this->scope = new Scope($parent_scope);
        foreach ($this->parameters as $param) {
            if ($this->scope->hasLocal($param->name)) {
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $parent_scope is not named in camelCase.
    Open

        public function injectScope($parent_scope)
    {
        $this->scope = new Scope($parent_scope);
        foreach ($this->parameters as $param) {
            if ($this->scope->hasLocal($param->name)) {
    Severity: Minor
    Found in src/ast/expr/LambdaExpr.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status