Sign upLogin

quack/quack

View on GitHub
Star

Showing 839 of 839 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * Quack Compiler and toolkit
 * Copyright (C) 2015-2017 Quack and CONTRIBUTORS
 *
Severity: Major
Found in src/ast/stmt/BreakStmt.php and 1 other location - About 2 days to fix
src/ast/stmt/ContinueStmt.php on lines 1..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 421.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * Quack Compiler and toolkit
 * Copyright (C) 2015-2017 Quack and CONTRIBUTORS
 *
Severity: Major
Found in src/ast/stmt/ContinueStmt.php and 1 other location - About 2 days to fix
src/ast/stmt/BreakStmt.php on lines 1..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 421.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function minify has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
Open

function minify($source, $pure_identifiers)
{
    static $name_map = [];
    static $pointer = 0;
Severity: Minor
Found in build.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Repl.php has 423 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Quack Compiler and toolkit
 * Copyright (C) 2015-2017 Quack and CONTRIBUTORS
 *
Severity: Minor
Found in src/cli/Repl.php - About 6 hrs to fix

    File build.php has 422 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Quack Compiler and toolkit
 * Copyright (C) 2015-2017 Quack and CONTRIBUTORS
 *
    Severity: Minor
    Found in build.php - About 6 hrs to fix

      Function digit has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

          public function digit()
    {
        $buffer = [];
        $number = $this->readChar();
      Severity: Minor
      Found in src/lexer/Tokenizer.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Repl has 32 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Repl extends Component
{
    private $console;
    private $croak;
    private $modules = [];
      Severity: Minor
      Found in src/cli/Repl.php - About 4 hrs to fix

        Method minify has 99 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function minify($source, $pure_identifiers)
{
    static $name_map = [];
    static $pointer = 0;
        Severity: Major
        Found in build.php - About 3 hrs to fix

          Function injectScope has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
          Open

              public function injectScope($parent_scope)
    {
        $this->scope = $parent_scope;
        $this->left->injectScope($parent_scope);
          Severity: Minor
          Found in src/ast/expr/OperatorExpr.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function nextToken has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
          Open

              public function nextToken()
    {
        while ($this->peek != self::EOF) {
            if (ctype_digit($this->peek)) {
                return $this->digit();
          Severity: Minor
          Found in src/lexer/Tokenizer.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getType has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getType()
    {
        $bool = $this->scope->getPrimitiveType('Bool');
        $type = (object) [
            'left'  => $this->left->getType(),
          Severity: Minor
          Found in src/ast/expr/OperatorExpr.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The class Parser has 11 public methods. Consider refactoring Parser to keep number of public methods under 10.
          Open

          abstract class Parser
{
    use Parselet;

    public $input;
          Severity: Minor
          Found in src/parser/Parser.php by phpmd

          TooManyPublicMethods

          Since: 0.1

          A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

          By default it ignores methods starting with 'get' or 'set'.

          Example

          Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

          The class StmtParser has 19 public methods. Consider refactoring StmtParser to keep number of public methods under 10.
          Open

          class StmtParser
{
    use Attachable;

    public $reader;
          Severity: Minor
          Found in src/parser/StmtParser.php by phpmd

          TooManyPublicMethods

          Since: 0.1

          A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

          By default it ignores methods starting with 'get' or 'set'.

          Example

          Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

          The class Repl has an overall complexity of 77 which is very high. The configured complexity threshold is 50.
          Open

          class Repl extends Component
{
    private $console;
    private $croak;
    private $modules = [];
          Severity: Minor
          Found in src/cli/Repl.php by phpmd

          The class Console has 16 public methods. Consider refactoring Console to keep number of public methods under 10.
          Open

          class Console
{
    private $stdin;
    private $stdout;
    private $stderr;
          Severity: Minor
          Found in src/cli/Console.php by phpmd

          TooManyPublicMethods

          Since: 0.1

          A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

          By default it ignores methods starting with 'get' or 'set'.

          Example

          Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

          The class Repl has 31 non-getter- and setter-methods. Consider refactoring Repl to keep number of methods under 25.
          Open

          class Repl extends Component
{
    private $console;
    private $croak;
    private $modules = [];
          Severity: Minor
          Found in src/cli/Repl.php by phpmd

          TooManyMethods

          Since: 0.1

          A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

          By default it ignores methods starting with 'get' or 'set'.

          The default was changed from 10 to 25 in PHPMD 2.3.

          Example

          Source https://phpmd.org/rules/codesize.html#toomanymethods

          The class Tokenizer has an overall complexity of 80 which is very high. The configured complexity threshold is 50.
          Open

          class Tokenizer extends Lexer
{
    public $line = 1;
    public $column = 0;
          Severity: Minor
          Found in src/lexer/Tokenizer.php by phpmd

          Method digit has 68 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function digit()
    {
        $buffer = [];
        $number = $this->readChar();
          Severity: Major
          Found in src/lexer/Tokenizer.php - About 2 hrs to fix

            File Tokenizer.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
/**
 * Quack Compiler and toolkit
 * Copyright (C) 2015-2017 Quack and CONTRIBUTORS
 *
            Severity: Minor
            Found in src/lexer/Tokenizer.php - About 2 hrs to fix

              Method getType has 56 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getType()
    {
        $bool = $this->scope->getPrimitiveType('Bool');
        $type = (object) [
            'left'  => $this->left->getType(),
              Severity: Major
              Found in src/ast/expr/OperatorExpr.php - About 2 hrs to fix
                Severity
                Category
                Status
                Source
                Language