Function injectScope
has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getType
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getType
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
Method injectScope
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
Avoid too many return
statements within this method. Open
return $bool;
Avoid too many return
statements within this method. Open
return $bool;
Avoid too many return
statements within this method. Open
return $bool;
Avoid too many return
statements within this method. Open
return $this->scope->getPrimitiveType('Number');
The method getType() has an NPath complexity of 49920. The configured NPath complexity threshold is 200. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method getType() has a Cyclomatic Complexity of 24. The configured cyclomatic complexity threshold is 10. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method injectScope() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'getType'. Open
throw new TypeError(Localization::message('TYP100', [$type->right, $target]));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'getType'. Open
throw new TypeError(Localization::message('TYP110', [$op_name, $type->left, $op_name, $type->right]));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'getType'. Open
throw new TypeError(Localization::message('TYP110', [$op_name, $type->left, $op_name, $type->right]));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'injectScope'. Open
throw new ScopeError(Localization::message('SCO070', [$this->left->name]));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method injectScope uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// We have a range of specific nodes that are allowed
$valid_assignment = $this->left instanceof AccessExpr ||
$this->left instanceof ListExpr; // List destructuring
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'injectScope'. Open
throw new ScopeError(Localization::message('SCO080', [$this->left->name]));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Lexer\Tag' in method 'format'. Open
$source .= Tag::getOperatorLexeme($this->operator);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'injectScope'. Open
throw new ScopeError(Localization::message('SCO090', []));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Lexer\Tag' in method 'getType'. Open
$op_name = Tag::getOperatorLexeme($this->operator);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'getType'. Open
throw new TypeError(Localization::message('TYP090', [$type->left, $type->right]));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'getType'. Open
throw new TypeError(Localization::message('TYP130', [$type->left, $op_name, $type->right]));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'injectScope'. Open
throw new ScopeError(Localization::message('SCO100', []));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\QuackCompiler\Intl\Localization' in method 'getType'. Open
throw new TypeError(Localization::message('TYP110', [$op_name, $type->left, $op_name, $type->right]));
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
TODO found Open
// TODO: Implement destructuring on let, because this is currently useless
- Exclude checks
The parameter $parent_scope is not named in camelCase. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The variable $op_name is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $op_name is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $op_name is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $valid_assignment is not named in camelCase. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $valid_assignment is not named in camelCase. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $op_name is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $numeric_op is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $parent_scope is not named in camelCase. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $parent_scope is not named in camelCase. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $op_name is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $parent_scope is not named in camelCase. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $bool_op is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $op_name is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $numeric_op is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $eq_op is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $op_name is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $parent_scope is not named in camelCase. Open
public function injectScope($parent_scope)
{
$this->scope = $parent_scope;
$this->left->injectScope($parent_scope);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $eq_op is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $op_name is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $bool_op is not named in camelCase. Open
public function getType()
{
$bool = $this->scope->getPrimitiveType('Bool');
$type = (object) [
'left' => $this->left->getType(),
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}