Sign upLogin

quack/quack

View on GitHub
Star
src/lexer/Tag.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method getPartialOperators has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function & getPartialOperators()
    {
        static $op_table = [
            '+',
            '-',
Severity: Minor
Found in src/lexer/Tag.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                    return 'xor';
    Severity: Major
    Found in src/lexer/Tag.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $op;
      Severity: Major
      Found in src/lexer/Tag.php - About 30 mins to fix

        Avoid variables with short names like $op. Configured minimum length is 3.
        Open

            public static function getOperatorLexeme($op)
        Severity: Minor
        Found in src/lexer/Tag.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        The variable $op_table is not named in camelCase.
        Open

            public static function & getPartialOperators()
    {
        static $op_table = [
            '+',
            '-',
        Severity: Minor
        Found in src/lexer/Tag.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $token_name is not named in camelCase.
        Open

            public static function getName($tag)
    {
        $token_name = array_search($tag, (new ReflectionClass(__CLASS__))->getConstants(), true);
        // Yeah, I need to do a strict check here (for the glory of Satan of course)
        return false === $token_name ? $tag : $token_name;
        Severity: Minor
        Found in src/lexer/Tag.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $token_name is not named in camelCase.
        Open

            public static function getName($tag)
    {
        $token_name = array_search($tag, (new ReflectionClass(__CLASS__))->getConstants(), true);
        // Yeah, I need to do a strict check here (for the glory of Satan of course)
        return false === $token_name ? $tag : $token_name;
        Severity: Minor
        Found in src/lexer/Tag.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $token_name is not named in camelCase.
        Open

            public static function getName($tag)
    {
        $token_name = array_search($tag, (new ReflectionClass(__CLASS__))->getConstants(), true);
        // Yeah, I need to do a strict check here (for the glory of Satan of course)
        return false === $token_name ? $tag : $token_name;
        Severity: Minor
        Found in src/lexer/Tag.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        There are no issues that match your filters.

        Category
        Status