Function digit
has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open
public function digit()
{
$buffer = [];
$number = $this->readChar();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function nextToken
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
public function nextToken()
{
while ($this->peek != self::EOF) {
if (ctype_digit($this->peek)) {
return $this->digit();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The class Tokenizer has an overall complexity of 80 which is very high. The configured complexity threshold is 50. Open
class Tokenizer extends Lexer
{
public $line = 1;
public $column = 0;
- Exclude checks
Method digit
has 68 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function digit()
{
$buffer = [];
$number = $this->readChar();
File Tokenizer.php
has 266 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Quack Compiler and toolkit
* Copyright (C) 2015-2017 Quack and CONTRIBUTORS
*
Method nextToken
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function nextToken()
{
while ($this->peek != self::EOF) {
if (ctype_digit($this->peek)) {
return $this->digit();
Method regex
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function regex()
{
$buffer = [];
$buffer[] = $this->readChar();
$buffer[] = $this->readChar();
Function regex
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
private function regex()
{
$buffer = [];
$buffer[] = $this->readChar();
$buffer[] = $this->readChar();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return SymbolDecypher::{$this->peek}($this);
Avoid too many return
statements within this method. Open
return $this->regex();
Avoid too many return
statements within this method. Open
return new Token(self::EOF_TYPE);
Avoid too many return
statements within this method. Open
return $this->string($this->peek);
The method digit() has an NPath complexity of 1428. The configured NPath complexity threshold is 200. Open
public function digit()
{
$buffer = [];
$number = $this->readChar();
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method nextToken() has an NPath complexity of 5761. The configured NPath complexity threshold is 200. Open
public function nextToken()
{
while ($this->peek != self::EOF) {
if (ctype_digit($this->peek)) {
return $this->digit();
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method digit() has a Cyclomatic Complexity of 23. The configured cyclomatic complexity threshold is 10. Open
public function digit()
{
$buffer = [];
$number = $this->readChar();
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method nextToken() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10. Open
public function nextToken()
{
while ($this->peek != self::EOF) {
if (ctype_digit($this->peek)) {
return $this->digit();
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid using undefined variables such as '$buffer' which will lead to PHP notices. Open
$buffer[] = $this->readChar();
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$buffer' which will lead to PHP notices. Open
$atom = implode($buffer);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
The method space uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->column++;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method digit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$bits = 0;
if (ctype_digit($this->preview())) { // check if is dec
if ($this->peek === 'b') {
$bits = 1;
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method regex uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->column--;
$this->stepback();
break;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'QuackCompiler\Lexer\SymbolDecypher' in method 'nextToken'. Open
return SymbolDecypher::{$this->peek}($this);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The variable $token_stream is not named in camelCase. Open
public function eagerlyEvaluate()
{
$this->rewind();
$token_stream = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $new_line is not named in camelCase. Open
private function space()
{
$new_line = array_map('ord', ["\r", "\n", "\r\n", PHP_EOL]);
do {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $allowed_modifiers is not named in camelCase. Open
private function regex()
{
$buffer = [];
$buffer[] = $this->readChar();
$buffer[] = $this->readChar();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $token_stream is not named in camelCase. Open
public function eagerlyEvaluate()
{
$this->rewind();
$token_stream = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $new_line is not named in camelCase. Open
private function space()
{
$new_line = array_map('ord', ["\r", "\n", "\r\n", PHP_EOL]);
do {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $allowed_modifiers is not named in camelCase. Open
private function regex()
{
$buffer = [];
$buffer[] = $this->readChar();
$buffer[] = $this->readChar();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $token_stream is not named in camelCase. Open
public function eagerlyEvaluate()
{
$this->rewind();
$token_stream = [];
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}