src/parselets/types/NameTypeParselet.php
The method __construct has a boolean flag argument $is_generic, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function __construct($is_generic = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The parameter $is_generic is not named in camelCase. Open
Open
public function __construct($is_generic = false)
{
$this->is_generic = $is_generic;
}- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The property $is_generic is not named in camelCase. Open
Open
class NameTypeParselet implements PrefixParselet
{
private $is_generic;
public function __construct($is_generic = false)- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The variable $is_generic is not named in camelCase. Open
Open
public function __construct($is_generic = false)
{
$this->is_generic = $is_generic;
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}