Sign upLogin

quack/quack

View on GitHub
Star
src/parser/DeclParser.php

Summary

Maintainability
A
0 mins
Test Coverage

The method _fnStmt uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $body = $this->stmt_parser->_stmtList();
            $this->reader->match(Tag::T_END);
        }
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid assigning values to variables in if clauses and the like (line '74', column '13').
Open

    public function _fnStmt()
    {
        $is_short = false;
        $body = null;
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

The variable $is_short is not named in camelCase.
Open

    public function _fnStmt()
    {
        $is_short = false;
        $body = null;
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $is_short is not named in camelCase.
Open

    public function _fnStmt()
    {
        $is_short = false;
        $body = null;
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $is_short is not named in camelCase.
Open

    public function _fnStmt()
    {
        $is_short = false;
        $body = null;
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method _typeConsStmt is not named in camelCase.
Open

    public function _typeConsStmt()
    {
        $name = $this->name_parser->_typename();
        $values = [];
        if ($this->reader->consumeIf('(')) {
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _fnSignature is not named in camelCase.
Open

    public function _fnSignature()
    {
        $name = null;
        $parameters = [];
        $type = null;
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _dataStmt is not named in camelCase.
Open

    public function _dataStmt()
    {
        $this->reader->match(Tag::T_DATA);
        $name = $this->name_parser->_typename();
        $parameters = [];
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _fnStmt is not named in camelCase.
Open

    public function _fnStmt()
    {
        $is_short = false;
        $body = null;
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _typeStmt is not named in camelCase.
Open

    public function _typeStmt()
    {
        $this->reader->match(Tag::T_TYPE);
        $name = $this->name_parser->_typename();
        $this->reader->match(':-');
Severity: Minor
Found in src/parser/DeclParser.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status