src/parser/TypeParser.php
The class TypeParser has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13. Open
Open
class TypeParser
{
use Attachable;
use Parselet;
- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
The variable $error_params is not named in camelCase. Open
Open
public function _type($precedence = 0)
{
$token = $this->reader->lookahead;
$prefix = $this->prefixParseletForToken($token);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $error_params is not named in camelCase. Open
Open
public function _type($precedence = 0)
{
$token = $this->reader->lookahead;
$prefix = $this->prefixParseletForToken($token);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $error_params is not named in camelCase. Open
Open
public function _type($precedence = 0)
{
$token = $this->reader->lookahead;
$prefix = $this->prefixParseletForToken($token);
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The method _type is not named in camelCase. Open
Open
public function _type($precedence = 0)
{
$token = $this->reader->lookahead;
$prefix = $this->prefixParseletForToken($token);
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}