Sign upLogin

rafal-r/airr-react

View on GitHub
Star

Showing 26 of 26 total issues

File Sidepanel.tsx has 372 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as React from "react";
import { PureComponent, ReactNode, RefObject, CSSProperties } from "react";
import { isMobileDevice, supportPassive } from "./eventHelpers";
import { Placement, TouchPosition } from "./Airr";
import {
Severity: Minor
Found in lib/Sidepanel.tsx - About 4 hrs to fix

    Function NavbarRenderer has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

    const NavbarRenderer = React.memo<NavbarRendererProps>(function NavbarRenderer({
    navbar,
    activeViewIndex,
    backButtonOnFirstView,
    handleBackButton,
    Severity: Minor
    Found in lib/SceneRenderer/NavbarRenderer.tsx - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Scene.tsx has 300 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as React from "react";
import { ReactNode, RefObject, PureComponent } from "react";
import SceneRenderer, { sceneDefaultProps } from "./SceneRenderer";
import Sidepanel from "./Sidepanel";
import View, { CommonViewClass } from "./View";
    Severity: Minor
    Found in lib/Scene.tsx - About 3 hrs to fix

      Scene has 26 functions (exceeds 20 allowed). Consider refactoring.
      Open

      export default class Scene<P extends SceneProps = SceneProps, S extends SceneState = SceneState>
    extends PureComponent<P, S>
    implements CommonViewClass {
    static defaultProps = {
        ...sceneDefaultProps,
      Severity: Minor
      Found in lib/Scene.tsx - About 3 hrs to fix

        Function render has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            render(): ReactNode {
        let className = "airr-view airr-scene";
        this.props.active && (className += " active");
        this.props.className && (className += " " + this.props.className);
        Severity: Major
        Found in lib/SceneRenderer.tsx - About 2 hrs to fix

          Function changeView has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              static changeView(
        scene: Scene,
        view: string | ViewConfig<CommonViewProps>,
        viewProps: ViewProps | {} = {},
        sceneProps: SceneProps | {} = {}
          Severity: Minor
          Found in lib/Scene/ViewsAPIHelper.ts - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            const NavbarRenderer = React.memo<NavbarRendererProps>(function NavbarRenderer({
    navbar,
    activeViewIndex,
    backButtonOnFirstView,
    handleBackButton,
            Severity: Major
            Found in lib/SceneRenderer/NavbarRenderer.tsx and 1 other location - About 1 hr to fix
            lib/Scene/ViewsAnimationHelpers.ts on lines 37..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function doViewsAnimation({
    newViewComp,
    oldViewComp,
    newViewIndex,
    oldViewIndex,
            Severity: Major
            Found in lib/Scene/ViewsAnimationHelpers.ts and 1 other location - About 1 hr to fix
            lib/SceneRenderer/NavbarRenderer.tsx on lines 20..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function getViewsTransitionConfig has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function getViewsTransitionConfig(
    newViewName: string,
    scene: Scene,
    callback: () => void
): PerformViewsTransitionConfig {
            Severity: Minor
            Found in lib/Scene/ViewsAnimationHelpers.ts - About 1 hr to fix

              Function doBackButtonAnimation has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export function doBackButtonAnimation(
    type: "hide" | "show",
    element: HTMLElement,
    animationTime: number
): void {
              Severity: Minor
              Found in lib/Scene/ItemsAnimationHelpers.ts - About 1 hr to fix

                Function performViewsAnimation has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    static performViewsAnimation(scene: Scene, newViewName: string): Promise<void> {
        if (typeof newViewName === "string") {
            scene.viewChangeInProgress = true;

            return new Promise(
                Severity: Minor
                Found in lib/Scene/ViewsAPIHelper.ts - About 1 hr to fix

                  Function getOverlayAnimationConfig has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function getOverlayAnimationConfig(config: OverlayAnimationConfig): TransitionAnimationConfig {
    const { dom, width, height, t, callback, headTo, appearFrom } = config;
    let startProps: TransitionAnimationConfig["startProps"],
        endProps: TransitionAnimationConfig["endProps"],
        transform: string,
                  Severity: Minor
                  Found in lib/MayerHelper.ts - About 1 hr to fix

                    Function render has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        render(): ReactNode {
        let className = "airr-view airr-scene";
        this.props.active && (className += " active");
        this.props.className && (className += " " + this.props.className);
                    Severity: Minor
                    Found in lib/SceneRenderer.tsx - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function doVerticalScrollAnimation has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function doVerticalScrollAnimation(
    element: HTMLElement,
    scrollDuration: number,
    direction: Placement
): void {
                    Severity: Minor
                    Found in lib/FX.ts - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function doNavbarItemsAnimation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function doNavbarItemsAnimation({
    newViewIndex,
    oldViewIndex,
    direction,
    titleNode,
                    Severity: Minor
                    Found in lib/Scene/ItemsAnimationHelpers.ts - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    interface ViewsRendererProps extends ViewsMapperProps {
    className: Props["className"];
    refDOMContainer: Props["refDOMContainer"];
    containersHeight: Props["containersHeight"];
}
                    Severity: Minor
                    Found in lib/SceneRenderer/ViewsRenderer.tsx and 1 other location - About 40 mins to fix
                    lib/SceneRenderer/ViewsMapper.tsx on lines 8..12

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 48.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export interface ViewsMapperProps {
    views: Props["views"];
    activeViewName: Props["activeViewName"];
    refsCOMPViews: Props["refsCOMPViews"];
}
                    Severity: Minor
                    Found in lib/SceneRenderer/ViewsMapper.tsx and 1 other location - About 40 mins to fix
                    lib/SceneRenderer/ViewsRenderer.tsx on lines 6..10

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 48.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function doViewsSlideAnimation has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        newViewDOM: HTMLElement,
    sceneWidth: number,
    ctnDOM: HTMLElement,
    direction: Direction,
    animationTime: number
                    Severity: Minor
                    Found in lib/Scene/ViewsFXHelpers.ts - About 35 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  this.hiddenVal = this.props.side === "top" ? -1 * this.size : this.props.sceneHeight;
                      Severity: Minor
                      Found in lib/Sidepanel.tsx and 1 other location - About 35 mins to fix
                      lib/Sidepanel.tsx on lines 426..426

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 47.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  this.hiddenVal = this.props.side === "left" ? -1 * this.size : this.props.sceneWidth;
                      Severity: Minor
                      Found in lib/Sidepanel.tsx and 1 other location - About 35 mins to fix
                      lib/Sidepanel.tsx on lines 433..433

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 47.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language