Sign upLogin

rakuten-ws/rws-ruby-sdk

View on GitHub
Star

Showing 133 of 133 total issues

Align the parameters of a method call if they span more than one line.
Open

        :reviewCount, :reviewAverage,
Severity: Minor
Found in lib/rakuten_web_service/kobo/ebook.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Missing top-level class documentation comment.
Open

  class BaseGenre < RakutenWebService::Resource
Severity: Minor
Found in lib/rakuten_web_service/genre.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Rename has_required_options? to required_options?.
Open

    def has_required_options?
Severity: Minor
Found in lib/rakuten_web_service/configuration.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Line is too long. [122/80]
Open

                :meal, :course, :costperformance, :distance, :fairway, :reserveCalUrl, :voiceUrl, :layoutUrl, :routeMapUrl
Severity: Minor
Found in lib/rakuten_web_service/gora/course_detail.rb by rubocop

Missing top-level class documentation comment.
Open

    class ForeignBook < Books::Resource
Severity: Minor
Found in lib/rakuten_web_service/books/foreign_book.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

    class Total < Books::Resource
Severity: Minor
Found in lib/rakuten_web_service/books/total.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

    class Magazine < Books::Resource
Severity: Minor
Found in lib/rakuten_web_service/books/magazine.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer $INPUT_RECORD_SEPARATOR or $RS from the stdlib 'English' module (don't forget to require it) over $/.
Open

  spec.files         = `git ls-files`.split($/)
Severity: Minor
Found in rakuten_web_service.gemspec by rubocop

Missing top-level module documentation comment.
Open

module RakutenWebService
Severity: Minor
Found in lib/rakuten_web_service.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [114/80]
Open

    USER_AGENT = "RakutenWebService SDK for Ruby v#{RWS::VERSION}(ruby-#{RUBY_VERSION} [#{RUBY_PLATFORM}])".freeze
Severity: Minor
Found in lib/rakuten_web_service/client.rb by rubocop

Line is too long. [84/80]
Open

      @children = params['children'].map { |child| genre_class.new(child['child']) }
Severity: Minor
Found in lib/rakuten_web_service/genre_information.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

        :itemUrl, :affiliateUrl,
Severity: Minor
Found in lib/rakuten_web_service/kobo/ebook.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Line is too long. [112/80]
Open

        attribute :planId, :planName, :planType, :limitedTimeFlag, :price, :basePrice, :salesTax, :courseUseTax,
Severity: Minor
Found in lib/rakuten_web_service/gora/plan.rb by rubocop

Line is too long. [98/80]
Open

          attribute :playDate, :stockStatus, :stockCount, :reservePageUrlPC, :reservePageUrlMobile
Severity: Minor
Found in lib/rakuten_web_service/gora/plan.rb by rubocop

Missing top-level class documentation comment.
Open

    class Course < Resource
Severity: Minor
Found in lib/rakuten_web_service/gora/course.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [117/80]
Open

                :golfCourseImageUrl5, :weekdayMinPrice, :baseWeekdayMinPrice, :holidayMinPrice, :baseHolidayMinPrice,
Severity: Minor
Found in lib/rakuten_web_service/gora/course_detail.rb by rubocop

Line is too long. [120/80]
Open

                :designer, :courseType, :courseVerticalInterval, :dimension, :green, :greenCount, :holeCount, :parCount,
Severity: Minor
Found in lib/rakuten_web_service/gora/course_detail.rb by rubocop

Line is too long. [117/80]
Open

        attribute :title, :nickName, :prefecture, :age, :sex, :times, :evaluation, :staff, :facility, :meal, :course,
Severity: Minor
Found in lib/rakuten_web_service/gora/course_detail.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

        :averagePrice,
Severity: Minor
Found in lib/rakuten_web_service/ichiba/product.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Align the parameters of a method call if they span more than one line.
Open

        :ProductDetails
Severity: Minor
Found in lib/rakuten_web_service/ichiba/product.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz
Severity
Category
Status
Source
Language