Sign upLogin

rambler-digital-solutions/Generamba

View on GitHub
Star

Showing 840 of 840 total issues

Line is too long. [86/80]
Open

        targets_const_value = Generamba.const_get(target_type.upcase + '_TARGETS_KEY')
Severity: Minor
Found in lib/generamba/helpers/module_validator.rb by rubocop

Provide an exception class and message as arguments to raise.
Open

        raise StandardError.new(error_description)
Severity: Minor
Found in lib/generamba/template/installer/remote_installer.rb by rubocop

This cop checks the args passed to fail and raise. For exploded style (default), it recommends passing the exception class and message to raise, rather than construct an instance of the error. It will still allow passing just a message, or the construction of an error with more than one argument.

The exploded style works identically, but with the addition that it will also suggest constructing error objects when the exception is passed multiple arguments.

Example: EnforcedStyle: exploded (default)

# bad
raise StandardError.new("message")

# good
raise StandardError, "message"
fail "message"
raise MyCustomError.new(arg1, arg2, arg3)
raise MyKwArgError.new(key1: val1, key2: val2)

Example: EnforcedStyle: compact

# bad
raise StandardError, "message"
raise RuntimeError, arg1, arg2, arg3

# good
raise StandardError.new("message")
raise MyCustomError.new(arg1, arg2, arg3)
fail "message"

Final newline missing.
Open

end
Severity: Minor
Found in lib/generamba/template/installer/template_installer_factory.rb by rubocop

Freeze mutable objects assigned to constants.
Open

  CREATE_LOGICAL_GROUPS_KEY = 'create_logical_groups'
Severity: Minor
Found in lib/generamba/constants/rambafile_constants.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Freeze mutable objects assigned to constants.
Open

  GENERAMBA_CATALOG_NAME = 'generamba-catalog'
Severity: Minor
Found in lib/generamba/constants/constants.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Freeze mutable objects assigned to constants.
Open

  USERNAME_KEY = 'username'
Severity: Minor
Found in lib/generamba/constants/user_preferences_constants.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if not_existing_dependency.count > 0
Severity: Minor
Found in lib/generamba/helpers/dependency_checker.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Line is too long. [87/80]
Open

        Git.export(repo_url, template_name, :branch => repo_branch, :path => temp_path)
Severity: Minor
Found in lib/generamba/template/installer/remote_installer.rb by rubocop

Redundant return detected.
Open

          return Generamba::RemoteInstaller.new
Severity: Minor
Found in lib/generamba/template/installer/template_installer_factory.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Freeze mutable objects assigned to constants.
Open

  PROJECT_PREFIX_KEY = 'prefix'
Severity: Minor
Found in lib/generamba/constants/rambafile_constants.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Freeze mutable objects assigned to constants.
Open

  PROJECT_FILE_PATH_KEY = 'project_file_path'
Severity: Minor
Found in lib/generamba/constants/rambafile_constants.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Extra empty line detected at module body beginning.
Open


  # Abstract template installer class
Severity: Minor
Found in lib/generamba/template/installer/abstract_installer.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Freeze mutable objects assigned to constants.
Open

  PODFILE_PATH_KEY = 'podfile_path'
Severity: Minor
Found in lib/generamba/constants/rambafile_constants.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Freeze mutable objects assigned to constants.
Open

  TEMPLATE_DECLARATION_BRANCH_KEY = 'branch'
Severity: Minor
Found in lib/generamba/constants/rambafile_constants.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Provide an exception class and message as arguments to raise.
Open

        raise StandardError.new(error_description)
Severity: Minor
Found in lib/generamba/template/installer/local_installer.rb by rubocop

This cop checks the args passed to fail and raise. For exploded style (default), it recommends passing the exception class and message to raise, rather than construct an instance of the error. It will still allow passing just a message, or the construction of an error with more than one argument.

The exploded style works identically, but with the addition that it will also suggest constructing error objects when the exception is passed multiple arguments.

Example: EnforcedStyle: exploded (default)

# bad
raise StandardError.new("message")

# good
raise StandardError, "message"
fail "message"
raise MyCustomError.new(arg1, arg2, arg3)
raise MyKwArgError.new(key1: val1, key2: val2)

Example: EnforcedStyle: compact

# bad
raise StandardError, "message"
raise RuntimeError, arg1, arg2, arg3

# good
raise StandardError.new("message")
raise MyCustomError.new(arg1, arg2, arg3)
fail "message"

Freeze mutable objects assigned to constants.
Open

  RAMBAFILE_NAME = 'Rambafile'
Severity: Minor
Found in lib/generamba/constants/constants.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Extra empty line detected at module body beginning.
Open


  # Keys of file user_preferences.yml
Severity: Minor
Found in lib/generamba/constants/user_preferences_constants.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Freeze mutable objects assigned to constants.
Open

  TEMPLATE_LICENSE_KEY = 'license'
Severity: Minor
Found in lib/generamba/constants/rambaspec_constants.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Extra empty line detected at module body beginning.
Open


  # Incapsulates the logic of fetching remote templates, verifying and installing them
Severity: Minor
Found in lib/generamba/template/installer/remote_installer.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Line is too long. [84/80]
Open

        target_const_value = Generamba.const_get(target_type.upcase + '_TARGET_KEY')
Severity: Minor
Found in lib/generamba/helpers/module_validator.rb by rubocop
Severity
Category
Status
Source
Language