Sign upLogin

rambler-digital-solutions/Generamba

View on GitHub
Star

Showing 840 of 840 total issues

Line is too long. [87/80]
Open

    desc 'create [TEMPLATE_NAME]', 'Creates a new Generamba template with a given name'
Severity: Minor
Found in lib/generamba/cli/template/template_create_command.rb by rubocop

Final newline missing.
Open

end
Severity: Minor
Found in lib/generamba/cli/setup_username_command.rb by rubocop

Space missing after comma.
Open

        value_index = ask_with_validation(message,->(value){ (value.to_i >= 0 and value.to_i < array.count) },"Invalid selection. Please enter number from 0 to #{array.count-1}")
Severity: Minor
Found in lib/generamba/cli/thor_extension.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Space missing after comma.
Open

      project_target = ask_index("Select the appropriate target for adding your MODULES (type the index):\n" + targets_prompt,project.targets)
Severity: Minor
Found in lib/generamba/cli/setup_command.rb by rubocop

Checks for comma (,) not followed by some kind of space.

Example:

# bad
[1,2]
{ foo:bar,}

# good
[1, 2]
{ foo:bar, }

Freeze mutable objects assigned to constants.
Open

    TARGET_TYPE_TEST = 'test'
Severity: Minor
Found in lib/generamba/helpers/module_validator.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Use 2 (not 4) spaces for indentation.
Open

          file_path = root_path
Severity: Minor
Found in lib/generamba/helpers/xcodeproj_helper.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Use 2 (not 4) spaces for indentation.
Open

              next_group = group_is_logical ? final_group.new_group(group_name) : final_group.new_group(group_name, dir_path, :project)
Severity: Minor
Found in lib/generamba/helpers/xcodeproj_helper.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Tab detected.
Open

            filename_template = self.file_name_template(file)
Severity: Minor
Found in lib/generamba/code_generation/content_generator.rb by rubocop

Tab detected.
Open

            module_info = scope['module_info']
Severity: Minor
Found in lib/generamba/code_generation/content_generator.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

                :test_file_root,
Severity: Minor
Found in lib/generamba/code_generation/code_module.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Line is too long. [109/80]
Open

      @product_module_name = @project_name.gsub(C99IDENTIFIER, '_') if !@product_module_name && @project_name
Severity: Minor
Found in lib/generamba/code_generation/code_module.rb by rubocop

Line is too long. [107/80]
Open

      @create_logical_groups = rambafile[CREATE_LOGICAL_GROUPS_KEY] if rambafile[CREATE_LOGICAL_GROUPS_KEY]
Severity: Minor
Found in lib/generamba/code_generation/code_module.rb by rubocop

Line is too long. [101/80]
Open

      setup_file_and_group_paths(options[:test_file_path], options[:test_group_path], PATH_TYPE_TEST)
Severity: Minor
Found in lib/generamba/code_generation/code_module.rb by rubocop

Final newline missing.
Open

end
Severity: Minor
Found in lib/generamba/code_generation/rambafile_generator.rb by rubocop

Freeze mutable objects assigned to constants.
Open

  RELEASE_DATE = '11.08.2019'
Severity: Minor
Found in lib/generamba/version.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Align the parameters of a method call if they span more than one line.
Open

                                                                                                                file_is_resource)
Severity: Minor
Found in lib/generamba/module_generator.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Extra blank line detected.
Open


            # Creating test files
Severity: Minor
Found in lib/generamba/module_generator.rb by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Tab detected.
Open

            project.save
Severity: Minor
Found in lib/generamba/module_generator.rb by rubocop

Tab detected.
Open

            # It's possible that current project doesn't test targets configured, so it doesn't need to generate tests.
Severity: Minor
Found in lib/generamba/module_generator.rb by rubocop

Tab detected.
Open

                    XcodeprojHelper.add_group_to_project(project, group_path, dir_path, directory_name, code_module.create_logical_groups)
Severity: Minor
Found in lib/generamba/module_generator.rb by rubocop
Severity
Category
Status
Source
Language