rapid7/metasploit-framework

View on GitHub

Showing 22,177 of 22,177 total issues

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  def ensure_clean_destination(path)
    return unless file?(path)

    print_status("#{path} already exists on the target. Deleting...")
    begin
modules/exploits/windows/local/comahawk.rb on lines 135..145
modules/exploits/windows/local/cve_2020_0668_service_tracing.rb on lines 314..324
modules/exploits/windows/local/cve_2020_1048_printerdemon.rb on lines 184..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  def ensure_clean_destination(path)
    return unless file?(path)

    print_status("#{path} already exists on the target. Deleting...")
    begin
Severity: Major
Found in modules/exploits/windows/local/cve_2020_1048_printerdemon.rb and 3 other locations - About 30 mins to fix
modules/exploits/windows/local/comahawk.rb on lines 135..145
modules/exploits/windows/local/cve_2020_0668_service_tracing.rb on lines 314..324
modules/exploits/windows/local/cve_2020_1313_system_orchestrator.rb on lines 162..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  def ensure_clean_destination(path)
    return unless file?(path)

    print_status("#{path} already exists on the target. Deleting...")
    begin
modules/exploits/windows/local/comahawk.rb on lines 135..145
modules/exploits/windows/local/cve_2020_1048_printerdemon.rb on lines 184..194
modules/exploits/windows/local/cve_2020_1313_system_orchestrator.rb on lines 162..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

  def ensure_clean_destination(path)
    return unless file?(path)

    print_status("#{path} already exists on the target. Deleting...")
    begin
Severity: Major
Found in modules/exploits/windows/local/comahawk.rb and 3 other locations - About 30 mins to fix
modules/exploits/windows/local/cve_2020_0668_service_tracing.rb on lines 314..324
modules/exploits/windows/local/cve_2020_1048_printerdemon.rb on lines 184..194
modules/exploits/windows/local/cve_2020_1313_system_orchestrator.rb on lines 162..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'         => 'SAP Management Console Instance Properties',
      'Description'  => %q{
        This module simply attempts to identify the instance properties
modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb on lines 12..33
modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb on lines 12..35
modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 6.1.2',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20099280+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 37..48
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 53..64
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 85..96
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 101..112
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 117..128
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 133..144
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 149..160
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 165..176
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 181..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'         => 'SAP Management Console getStartProfile',
      'Description'  => %q{
        This module simply attempts to access the SAP startup profile
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb and 9 other locations - About 30 mins to fix
modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb on lines 12..33
modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb on lines 12..35
modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'           => 'SAP BusinessObjects User Enumeration',
      'Description'    => %Q{
        This module simply attempts to enumerate SAP BusinessObjects
modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb on lines 12..33
modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'         => 'SAP Management Console Version Detection',
      'Description'  => %q{
        This module simply attempts to identify the version of SAP
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb and 9 other locations - About 30 mins to fix
modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb on lines 12..33
modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb on lines 12..35
modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 6.1.0',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20099280+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 37..48
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 53..64
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 69..80
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 85..96
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 117..128
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 133..144
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 149..160
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 165..176
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 181..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 5.3.10 5.3.9 5.3.8 5.3.7',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20096ba0+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 37..48
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 53..64
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 69..80
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 85..96
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 101..112
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 133..144
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 149..160
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 165..176
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 181..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 5.3.8',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20096c10+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 37..48
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 53..64
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 69..80
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 85..96
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 101..112
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 117..128
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 133..144
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 149..160
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 181..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def self.registered(app)
    app.get self.api_path, &get_loot
    app.get self.api_path_with_id, &get_loot
    app.post self.api_path, &report_loot
    app.put self.api_path_with_id, &update_loot
Severity: Major
Found in lib/msf/core/web_services/servlet/loot_servlet.rb and 8 other locations - About 30 mins to fix
lib/msf/core/web_services/servlet/credential_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/login_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/note_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/payload_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/service_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/user_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/vuln_servlet.rb on lines 13..19
lib/msf/core/web_services/servlet/workspace_servlet.rb on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'           => 'SAP BusinessObjects User Bruteforcer',
      'Description'    => 'This module attempts to bruteforce SAP BusinessObjects users.
        The dswsbobje interface is only used to verify valid credentials for CmcApp.
modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb on lines 12..35
modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def self.registered(app)
    app.get self.api_path, &get_vuln
    app.get self.api_path_with_id, &get_vuln
    app.post self.api_path, &report_vuln
    app.put self.api_path_with_id, &update_vuln
Severity: Major
Found in lib/msf/core/web_services/servlet/vuln_servlet.rb and 8 other locations - About 30 mins to fix
lib/msf/core/web_services/servlet/credential_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/login_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/loot_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/note_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/payload_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/service_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/user_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/workspace_servlet.rb on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'         => 'SAP Management Console Get Access Points',
      'Description'  => %q{
        This module simply attempts to output a list of SAP access points through the
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb and 9 other locations - About 30 mins to fix
modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb on lines 12..33
modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb on lines 12..35
modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 5.3.10',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20096bf0+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 37..48
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 53..64
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 69..80
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 85..96
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 101..112
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 117..128
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 149..160
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 165..176
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 181..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'         => 'SAP Management Console ABAP Syslog Disclosure',
      'Description'  => %q{ This module simply attempts to extract the ABAP syslog through the SAP Management Console SOAP Interface. },
      'References'   =>
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb and 9 other locations - About 30 mins to fix
modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb on lines 12..33
modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb on lines 12..35
modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'         => 'SAP Management Console Extract Users',
      'Description'  =>  %q{
        This module simply attempts to extract SAP users from the ABAP
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb and 9 other locations - About 30 mins to fix
modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb on lines 12..33
modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb on lines 12..35
modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def self.registered(app)
    app.get self.api_path, &get_credentials
    app.get self.api_path_with_id, &get_credentials
    app.post self.api_path, &create_credential
    app.put self.api_path_with_id, &update_credential
Severity: Major
Found in lib/msf/core/web_services/servlet/credential_servlet.rb and 8 other locations - About 30 mins to fix
lib/msf/core/web_services/servlet/login_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/loot_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/note_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/payload_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/service_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/user_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/vuln_servlet.rb on lines 13..19
lib/msf/core/web_services/servlet/workspace_servlet.rb on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language