Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star

Showing 22,177 of 22,177 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  def exploit
    unless datastore['CMD'].blank?
      print_status("Executing command '#{datastore['CMD']}'")
      execute_command(datastore['CMD'])
      return
Severity: Minor
Found in modules/exploits/windows/antivirus/ams_xfr.rb and 2 other locations - About 30 mins to fix
modules/exploits/windows/http/ca_totaldefense_regeneratereports.rb on lines 110..125
modules/exploits/windows/http/osb_uname_jlist.rb on lines 92..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def self.registered(app)
    app.get self.api_path, &get_user
    app.get self.api_path_with_id, &get_user
    app.post self.api_path, &report_user
    app.put self.api_path_with_id, &update_user
Severity: Major
Found in lib/msf/core/web_services/servlet/user_servlet.rb and 8 other locations - About 30 mins to fix
lib/msf/core/web_services/servlet/credential_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/login_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/loot_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/note_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/payload_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/service_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/vuln_servlet.rb on lines 13..19
lib/msf/core/web_services/servlet/workspace_servlet.rb on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def self.registered(app)
    app.get  self.api_path, &get_services
    app.get  self.api_path_with_id, &get_services
    app.post self.api_path, &report_service
    app.put self.api_path_with_id, &update_service
Severity: Major
Found in lib/msf/core/web_services/servlet/service_servlet.rb and 8 other locations - About 30 mins to fix
lib/msf/core/web_services/servlet/credential_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/login_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/loot_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/note_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/payload_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/user_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/vuln_servlet.rb on lines 13..19
lib/msf/core/web_services/servlet/workspace_servlet.rb on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'         => 'SAP Management Console getEnvironment',
      'Description'  => %q{
        This module simply attempts to identify SAP Environment
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb and 9 other locations - About 30 mins to fix
modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb on lines 12..33
modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb on lines 12..35
modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def self.registered(app)
    app.get self.api_path, &get_note
    app.get self.api_path_with_id, &get_note
    app.post self.api_path, &report_note
    app.put self.api_path_with_id, &update_note
Severity: Major
Found in lib/msf/core/web_services/servlet/note_servlet.rb and 8 other locations - About 30 mins to fix
lib/msf/core/web_services/servlet/credential_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/login_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/loot_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/payload_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/service_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/user_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/vuln_servlet.rb on lines 13..19
lib/msf/core/web_services/servlet/workspace_servlet.rb on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 6.1.3',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20099280+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 37..48
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 69..80
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 85..96
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 101..112
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 117..128
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 133..144
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 149..160
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 165..176
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 181..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 6.1.1',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20099280+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 37..48
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 53..64
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 69..80
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 101..112
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 117..128
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 133..144
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 149..160
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 165..176
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 181..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  def exploit

    unless datastore['CMD'].blank?
      print_status("Executing command '#{datastore['CMD']}'")
      execute_command(datastore['CMD'])
Severity: Minor
Found in modules/exploits/windows/http/ca_totaldefense_regeneratereports.rb and 2 other locations - About 30 mins to fix
modules/exploits/windows/antivirus/ams_xfr.rb on lines 88..102
modules/exploits/windows/http/osb_uname_jlist.rb on lines 92..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def self.registered(app)
    app.get self.api_path, &get_logins
    app.get self.api_path_with_id, &get_logins
    app.post self.api_path, &create_login
    app.put self.api_path_with_id, &update_login
Severity: Major
Found in lib/msf/core/web_services/servlet/login_servlet.rb and 8 other locations - About 30 mins to fix
lib/msf/core/web_services/servlet/credential_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/loot_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/note_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/payload_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/service_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/user_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/vuln_servlet.rb on lines 13..19
lib/msf/core/web_services/servlet/workspace_servlet.rb on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  def initialize
    super(
      'Name'           => 'SAP BusinessObjects Version Detection',
      'Description'    => 'This module simply attempts to identify the version of SAP BusinessObjects.',
      'References'  =>
Severity: Major
Found in modules/auxiliary/scanner/http/sap_businessobjects_version_enum.rb and 9 other locations - About 30 mins to fix
modules/auxiliary/scanner/http/sap_businessobjects_user_brute.rb on lines 12..33
modules/auxiliary/scanner/http/sap_businessobjects_user_enum.rb on lines 12..35
modules/auxiliary/scanner/sap/sap_mgmt_con_abaplog.rb on lines 11..29
modules/auxiliary/scanner/sap/sap_mgmt_con_extractusers.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getaccesspoints.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_getenv.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_startprofile.rb on lines 11..32
modules/auxiliary/scanner/sap/sap_mgmt_con_version.rb on lines 11..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 6.1.4',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20099430+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 53..64
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 69..80
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 85..96
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 101..112
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 117..128
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 133..144
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 149..160
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 165..176
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 181..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

    def self.registered(app)
      app.get self.api_path, &get_workspace
      app.get self.api_path_with_id, &get_workspace
      app.post self.api_path, &add_workspace
      app.put self.api_path_with_id, &update_workspace
Severity: Major
Found in lib/msf/core/web_services/servlet/workspace_servlet.rb and 8 other locations - About 30 mins to fix
lib/msf/core/web_services/servlet/credential_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/login_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/loot_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/note_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/payload_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/service_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/user_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/vuln_servlet.rb on lines 13..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 5.3.9',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20096ba0+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 37..48
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 53..64
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 69..80
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 85..96
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 101..112
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 117..128
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 133..144
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 165..176
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 181..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  def self.registered(app)
    app.get self.api_path, &get_payload
    app.get self.api_path_with_id, &get_payload
    app.post self.api_path, &create_payload
    app.put self.api_path_with_id, &update_payload
Severity: Major
Found in lib/msf/core/web_services/servlet/payload_servlet.rb and 8 other locations - About 30 mins to fix
lib/msf/core/web_services/servlet/credential_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/login_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/loot_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/note_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/service_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/user_servlet.rb on lines 11..17
lib/msf/core/web_services/servlet/vuln_servlet.rb on lines 13..19
lib/msf/core/web_services/servlet/workspace_servlet.rb on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  def exploit

    unless datastore['CMD'].blank?
      print_status("Executing command '#{datastore['CMD']}'")
      execute_command(datastore['CMD'])
Severity: Minor
Found in modules/exploits/windows/http/osb_uname_jlist.rb and 2 other locations - About 30 mins to fix
modules/exploits/windows/antivirus/ams_xfr.rb on lines 88..102
modules/exploits/windows/http/ca_totaldefense_regeneratereports.rb on lines 110..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

            'IBM AIX Version 5.3.7',
            {
              'Arch'     => 'ppc',
              'Platform' => 'aix',
              'Ret'      => 0x20096c10+4096,
Severity: Major
Found in modules/exploits/aix/rpc_ttdbserverd_realpath.rb and 9 other locations - About 30 mins to fix
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 37..48
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 53..64
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 69..80
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 85..96
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 101..112
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 117..128
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 133..144
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 149..160
modules/exploits/aix/rpc_ttdbserverd_realpath.rb on lines 165..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    register_options(
      [
        Opt::RPORT(443),
        OptBool.new('SSL', [true, 'Connect with TLS', true]),
        OptString.new('TARGETURI', [true,  "Default server path", '/']),
Severity: Major
Found in modules/exploits/multi/http/cisco_dcnm_upload_2019.rb and 6 other locations - About 30 mins to fix
modules/auxiliary/admin/http/manageengine_pmp_privesc.rb on lines 41..48
modules/auxiliary/gather/mcafee_epo_xxe.rb on lines 46..53
modules/exploits/linux/http/f5_icall_cmd.rb on lines 52..59
modules/exploits/linux/http/f5_icontrol_exec.rb on lines 39..46
modules/exploits/linux/http/lifesize_uvc_ping_rce.rb on lines 47..54
modules/exploits/windows/ibm/ibm_was_dmgr_java_deserialization_rce.rb on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    register_options(
      [
        Opt::RPORT(443),
        OptBool.new('SSL', [true, 'Use SSL', true]),
        OptString.new('TARGETURI', [true, 'The base path to the iControl installation', '/iControl/iControlPortal.cgi']),
Severity: Major
Found in modules/exploits/linux/http/f5_icall_cmd.rb and 6 other locations - About 30 mins to fix
modules/auxiliary/admin/http/manageengine_pmp_privesc.rb on lines 41..48
modules/auxiliary/gather/mcafee_epo_xxe.rb on lines 46..53
modules/exploits/linux/http/f5_icontrol_exec.rb on lines 39..46
modules/exploits/linux/http/lifesize_uvc_ping_rce.rb on lines 47..54
modules/exploits/multi/http/cisco_dcnm_upload_2019.rb on lines 63..70
modules/exploits/windows/ibm/ibm_was_dmgr_java_deserialization_rce.rb on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    register_options(
      [
        Opt::RPORT(8443),
        OptBool.new('SSL', [true, 'Use SSL', true]),
        OptString.new('TARGETURI', [ true, "Base ePO directory path", '/']),
Severity: Major
Found in modules/auxiliary/gather/mcafee_epo_xxe.rb and 6 other locations - About 30 mins to fix
modules/auxiliary/admin/http/manageengine_pmp_privesc.rb on lines 41..48
modules/exploits/linux/http/f5_icall_cmd.rb on lines 52..59
modules/exploits/linux/http/f5_icontrol_exec.rb on lines 39..46
modules/exploits/linux/http/lifesize_uvc_ping_rce.rb on lines 47..54
modules/exploits/multi/http/cisco_dcnm_upload_2019.rb on lines 63..70
modules/exploits/windows/ibm/ibm_was_dmgr_java_deserialization_rce.rb on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    register_options(
      [
        Opt::RPORT(7272),
        OptBool.new('SSL', [true, 'Use SSL', true]),
        OptString.new('USERNAME', [true, 'The username to login as', 'guest']),
Severity: Major
Found in modules/auxiliary/admin/http/manageengine_pmp_privesc.rb and 6 other locations - About 30 mins to fix
modules/auxiliary/gather/mcafee_epo_xxe.rb on lines 46..53
modules/exploits/linux/http/f5_icall_cmd.rb on lines 52..59
modules/exploits/linux/http/f5_icontrol_exec.rb on lines 39..46
modules/exploits/linux/http/lifesize_uvc_ping_rce.rb on lines 47..54
modules/exploits/multi/http/cisco_dcnm_upload_2019.rb on lines 63..70
modules/exploits/windows/ibm/ibm_was_dmgr_java_deserialization_rce.rb on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language