Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb

Summary

Maintainability
D
2 days
Test Coverage

File eyesofnetwork_autodiscovery_rce.rb has 364 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking
  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::CmdStager
  include Msf::Exploit::SQLi
Severity: Minor
Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 4 hrs to fix

    Method exploit has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

      def exploit
    if @version != '5.3'
      print_status "Target is EyesOfNetwork version #{@version}. Attempting exploitation using CVE-2020-9465."
      sqli_to_admin_session
    else
    Severity: Minor
    Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'            => 'EyesOfNetwork 5.1-5.3 AutoDiscovery Target Command Execution',
      'Description'     => %q{
        This module exploits multiple vulnerabilities in EyesOfNetwork version 5.1, 5.2
    Severity: Major
    Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 3 hrs to fix

      Method check has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

        def check
    vprint_status("Running check")

    res_css = send_request_cgi 'uri' => normalize_uri(target_uri.path, 'css/eonweb.css')
      Severity: Minor
      Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check
    vprint_status("Running check")

    res_css = send_request_cgi 'uri' => normalize_uri(target_uri.path, 'css/eonweb.css')
      Severity: Minor
      Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 1 hr to fix

        Method exploit has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def exploit
    if @version != '5.3'
      print_status "Target is EyesOfNetwork version #{@version}. Attempting exploitation using CVE-2020-9465."
      sqli_to_admin_session
    else
        Severity: Minor
        Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                return CheckCode::Safe("Target is EyesOfNetwork with API version #{api_version}.")
          Severity: Major
          Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Appears("Target is EyesOfNetwork 5.2 with API version #{api_version}.")
            Severity: Major
            Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return CheckCode::Safe('Target is not an EyesOfNetwork application.')
              Severity: Major
              Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return CheckCode::Detected('Could not determine EyesOfNetwork version.')
                Severity: Major
                Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return CheckCode::Appears("Target is EyesOfNetwork 5.3 or older with API version #{api_version}.")
                  Severity: Major
                  Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return CheckCode::NotVulnerable("Target is EyesOfNetwork version #{@version} and is not vulnerable.")
                    Severity: Major
                    Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return CheckCode::Unknown('Connection failed')
                      Severity: Major
                      Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                              return CheckCode::Detected("Could not determine EyesOfNetwork version. API version is #{api_version}")
                        Severity: Major
                        Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 30 mins to fix

                          Method verify_api_key has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            def verify_api_key(res)
    return false unless res.code == 200

    json_data = res.get_json_document
    json_res = json_data['result']
                          Severity: Minor
                          Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            def login(user, pass)
    vprint_status "Authenticating as #{user} ..."

    res = send_request_cgi({
      'method'    => 'POST',
                          Severity: Minor
                          Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method sqli_to_admin_session has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            def sqli_to_admin_session
    @sqli = create_sqli(dbms: MySQLi::TimeBasedBlind) do |payload|
      res = send_request_cgi({
        'method' => 'GET',
        'uri' => normalize_uri(target_uri.path, '/login.php'),
                          Severity: Minor
                          Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                                    [ 'Linux (x86)', {
            'Arch' => ARCH_X86,
            'Platform' => 'linux',
            'DefaultOptions' => {
              'PAYLOAD'     => 'linux/x86/meterpreter/reverse_tcp'
                          Severity: Major
                          Found in modules/exploits/linux/http/eyesofnetwork_autodiscovery_rce.rb and 4 other locations - About 35 mins to fix
                          modules/exploits/linux/http/klog_server_authenticate_user_unauth_command_injection.rb on lines 56..81
                          modules/exploits/linux/http/mida_solutions_eframework_ajaxreq_rce.rb on lines 44..69
                          modules/exploits/multi/misc/msf_rpc_console.rb on lines 34..44
                          modules/exploits/unix/webapp/bolt_authenticated_rce.rb on lines 51..76

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 34.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status