Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/multi/http/php_volunteer_upload_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method exploit has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def exploit
    base = normalize_uri(target_uri.path)
    base << '/' if base[-1, 1] != '/'

    # Login
Severity: Minor
Found in modules/exploits/multi/http/php_volunteer_upload_exec.rb - About 2 hrs to fix

    Method initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info={})
    super(update_info(info,
      'Name'           => "PHP Volunteer Management System v1.0.2 Arbitrary File Upload Vulnerability",
      'Description'    => %q{
          This module exploits a vulnerability found in PHP Volunteer Management System,
    Severity: Minor
    Found in modules/exploits/multi/http/php_volunteer_upload_exec.rb - About 1 hr to fix

      Method exploit has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def exploit
    base = normalize_uri(target_uri.path)
    base << '/' if base[-1, 1] != '/'

    # Login
      Severity: Minor
      Found in modules/exploits/multi/http/php_volunteer_upload_exec.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method upload has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def upload(base, cookie, fname, file, description)
    boundary = "----WebKitFormBoundary#{rand_text_alpha(10)}"

    endpoint = "#{rhost}"
    endpoint << ":#{rport}" if rport.to_i != 80
      Severity: Minor
      Found in modules/exploits/multi/http/php_volunteer_upload_exec.rb - About 1 hr to fix

        Method login has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def login(base, username, password)
    # Get cookie: PHPVolunteerManagent
    res = send_request_raw({
      'method' => 'GET',
      'uri'    => "#{base}index.php"
        Severity: Minor
        Found in modules/exploits/multi/http/php_volunteer_upload_exec.rb - About 1 hr to fix

          Method upload has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def upload(base, cookie, fname, file, description)
          Severity: Minor
          Found in modules/exploits/multi/http/php_volunteer_upload_exec.rb - About 35 mins to fix

            Method login has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def login(base, username, password)
    # Get cookie: PHPVolunteerManagent
    res = send_request_raw({
      'method' => 'GET',
      'uri'    => "#{base}index.php"
            Severity: Minor
            Found in modules/exploits/multi/http/php_volunteer_upload_exec.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                  return
            Severity: Major
            Found in modules/exploits/multi/http/php_volunteer_upload_exec.rb - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status