Sign upLogin

rapid7/ruby_smb

View on GitHub
Star
lib/ruby_smb/server/server_client/session_setup.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method do_session_setup_smb2 has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        def do_session_setup_smb2(request, session)
          @smb2_related_operations_state.delete(:session_id)

          session_id = request.smb2_header.session_id
          if session_id == 0
Severity: Minor
Found in lib/ruby_smb/server/server_client/session_setup.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_session_setup_smb2 has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def do_session_setup_smb2(request, session)
          @smb2_related_operations_state.delete(:session_id)

          session_id = request.smb2_header.session_id
          if session_id == 0
Severity: Minor
Found in lib/ruby_smb/server/server_client/session_setup.rb - About 1 hr to fix

    Method do_session_setup_andx_smb1 has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def do_session_setup_andx_smb1(request, session)
          session_id = request.smb_header.uid
          if session_id == 0
            session_id = rand(1..0x10000)
            session = @session_table[session_id] = Server::Session.new(session_id)
    Severity: Minor
    Found in lib/ruby_smb/server/server_client/session_setup.rb - About 1 hr to fix

      Method do_session_setup_andx_smb1 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def do_session_setup_andx_smb1(request, session)
          session_id = request.smb_header.uid
          if session_id == 0
            session_id = rand(1..0x10000)
            session = @session_table[session_id] = Server::Session.new(session_id)
      Severity: Minor
      Found in lib/ruby_smb/server/server_client/session_setup.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status