Sign upLogin

rapid7/ruby_smb

View on GitHub
Star
lib/ruby_smb/server/share/provider/disk/processor/create.rb

Summary

Maintainability
C
1 day
Test Coverage

Method do_create_smb2 has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

              def do_create_smb2(request)
                unless request.create_disposition == RubySMB::Dispositions::FILE_OPEN
                  logger.warn("Can not handle CREATE request for disposition: #{request.create_disposition}")
                  raise NotImplementedError
                end
Severity: Minor
Found in lib/ruby_smb/server/share/provider/disk/processor/create.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_create_smb2 has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

              def do_create_smb2(request)
                unless request.create_disposition == RubySMB::Dispositions::FILE_OPEN
                  logger.warn("Can not handle CREATE request for disposition: #{request.create_disposition}")
                  raise NotImplementedError
                end
Severity: Major
Found in lib/ruby_smb/server/share/provider/disk/processor/create.rb - About 3 hrs to fix

    Method do_nt_create_andx_smb1 has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                  def do_nt_create_andx_smb1(request)
                path = request.data_block.file_name.snapshot
                path = path.encode.gsub(/\/|\\/, File::SEPARATOR)
                path = path.delete_prefix(File::SEPARATOR)
                local_path = get_local_path(path)
    Severity: Minor
    Found in lib/ruby_smb/server/share/provider/disk/processor/create.rb - About 1 hr to fix

      Method do_nt_create_andx_smb1 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

                    def do_nt_create_andx_smb1(request)
                path = request.data_block.file_name.snapshot
                path = path.encode.gsub(/\/|\\/, File::SEPARATOR)
                path = path.delete_prefix(File::SEPARATOR)
                local_path = get_local_path(path)
      Severity: Minor
      Found in lib/ruby_smb/server/share/provider/disk/processor/create.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status