lib/ruby_smb/smb2/file.rb
Method read
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
Open
def read(bytes: size, offset: 0)
max_read = tree.client.server_max_read_size
max_read = 65536 unless tree.client.server_supports_multi_credit
atomic_read_size = [bytes, max_read].min
credit_charge = 0
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method read
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def read(bytes: size, offset: 0)
max_read = tree.client.server_max_read_size
max_read = 65536 unless tree.client.server_supports_multi_credit
atomic_read_size = [bytes, max_read].min
credit_charge = 0
Method write
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
def write(data:'', offset: 0)
max_write = tree.client.server_max_write_size
max_write = 65536 unless tree.client.server_supports_multi_credit
buffer = data.dup
bytes = data.length
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"