ravikalla/online-bank

View on GitHub

Showing 79 of 79 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        } else if (transferFrom.equalsIgnoreCase("Savings") && transferTo.equalsIgnoreCase("Primary")) {
            primaryAccount.setAccountBalance(primaryAccount.getAccountBalance().add(new BigDecimal(amount)));
            savingsAccount.setAccountBalance(savingsAccount.getAccountBalance().subtract(new BigDecimal(amount)));
            primaryAccountDao.save(primaryAccount);
            savingsAccountDao.save(savingsAccount);
src/main/java/in/ravikalla/cloudBank/service/UserServiceImpl/TransactionServiceImpl.java on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (transferFrom.equalsIgnoreCase("Primary") && transferTo.equalsIgnoreCase("Savings")) {
            primaryAccount.setAccountBalance(primaryAccount.getAccountBalance().subtract(new BigDecimal(amount)));
            savingsAccount.setAccountBalance(savingsAccount.getAccountBalance().add(new BigDecimal(amount)));
            primaryAccountDao.save(primaryAccount);
            savingsAccountDao.save(savingsAccount);
src/main/java/in/ravikalla/cloudBank/service/UserServiceImpl/TransactionServiceImpl.java on lines 89..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function backdrop has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  Modal.prototype.backdrop = function (callback) {
    var that = this
    var animate = this.$element.hasClass('fade') ? 'fade' : ''

    if (this.isShown && this.options.backdrop) {
Severity: Minor
Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

    Function show has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Modal.prototype.show = function (_relatedTarget) {
        var that = this
        var e    = $.Event('show.bs.modal', { relatedTarget: _relatedTarget })
    
        this.$element.trigger(e)
    Severity: Minor
    Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

      Function activate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        Tab.prototype.activate = function (element, container, callback) {
          var $active    = container.find('> .active')
          var transition = callback
            && $.support.transition
            && ($active.length && $active.hasClass('fade') || !!container.find('> .fade').length)
      Severity: Minor
      Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              if (!self) {
                self = new this.constructor(e.currentTarget, this.getDelegateOptions())
                $(e.currentTarget).data('bs.' + this.type, self)
              }
        Severity: Major
        Found in src/main/resources/static/js/bootstrap.js and 2 other locations - About 1 hr to fix
        src/main/resources/static/js/bootstrap.js on lines 1370..1373
        src/main/resources/static/js/bootstrap.js on lines 1407..1410

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            if (!self) {
              self = new this.constructor(obj.currentTarget, this.getDelegateOptions())
              $(obj.currentTarget).data('bs.' + this.type, self)
            }
        Severity: Major
        Found in src/main/resources/static/js/bootstrap.js and 2 other locations - About 1 hr to fix
        src/main/resources/static/js/bootstrap.js on lines 1370..1373
        src/main/resources/static/js/bootstrap.js on lines 1716..1719

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            if (!self) {
              self = new this.constructor(obj.currentTarget, this.getDelegateOptions())
              $(obj.currentTarget).data('bs.' + this.type, self)
            }
        Severity: Major
        Found in src/main/resources/static/js/bootstrap.js and 2 other locations - About 1 hr to fix
        src/main/resources/static/js/bootstrap.js on lines 1407..1410
        src/main/resources/static/js/bootstrap.js on lines 1716..1719

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function show has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          Collapse.prototype.show = function () {
            if (this.transitioning || this.$element.hasClass('in')) return
        
            var activesData
            var actives = this.$parent && this.$parent.children('.panel').children('.in, .collapsing')
        Severity: Minor
        Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

          Function applyPlacement has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            Tooltip.prototype.applyPlacement = function (offset, placement) {
              var $tip   = this.tip()
              var width  = $tip[0].offsetWidth
              var height = $tip[0].offsetHeight
          
          
          Severity: Minor
          Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @RequestMapping(AppConstants.URI_ACC_PRIMARY)
                public String primaryAccount(Model model, Principal principal) {
                    L.debug("40 : Start : AccountController.primaryAccount(...)");
            
                    List<PrimaryTransaction> primaryTransactionList = transactionService.findPrimaryTransactionList(principal.getName());
            src/main/java/in/ravikalla/cloudBank/controller/AccountController.java on lines 54..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @RequestMapping(AppConstants.URI_ACC_SAVINGS)
                public String savingsAccount(Model model, Principal principal) {
                    L.debug("55 : Start : AccountController.savingsAccount(...)");
                    List<SavingsTransaction> savingsTransactionList = transactionService.findSavingsTransactionList(principal.getName());
                    User user = userService.findByUsername(principal.getName());
            src/main/java/in/ravikalla/cloudBank/controller/AccountController.java on lines 39..52

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function show has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              Tab.prototype.show = function () {
                var $this    = this.element
                var $ul      = $this.closest('ul:not(.dropdown-menu)')
                var selector = $this.data('target')
            
            
            Severity: Minor
            Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

              Function checkPosition has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                Affix.prototype.checkPosition = function () {
                  if (!this.$element.is(':visible')) return
              
                  var height       = this.$element.height()
                  var offset       = this.options.offset
              Severity: Minor
              Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        } else if (accountType.equalsIgnoreCase("Savings")) {
                            savingsAccount.setAccountBalance(savingsAccount.getAccountBalance().subtract(new BigDecimal(amount)));
                            savingsAccountDao.save(savingsAccount);
                
                            Date date = new Date();
                src/main/java/in/ravikalla/cloudBank/service/UserServiceImpl/TransactionServiceImpl.java on lines 126..134

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (accountType.equalsIgnoreCase("Primary")) {
                            primaryAccount.setAccountBalance(primaryAccount.getAccountBalance().subtract(new BigDecimal(amount)));
                            primaryAccountDao.save(primaryAccount);
                
                            Date date = new Date();
                src/main/java/in/ravikalla/cloudBank/service/UserServiceImpl/TransactionServiceImpl.java on lines 134..142

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function refresh has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  ScrollSpy.prototype.refresh = function () {
                    var that          = this
                    var offsetMethod  = 'offset'
                    var offsetBase    = 0
                
                
                Severity: Minor
                Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

                  Function next has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function next() {
                        $active
                          .removeClass('active')
                          .find('> .dropdown-menu > .active')
                            .removeClass('active')
                  Severity: Minor
                  Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

                    Function hide has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      Collapse.prototype.hide = function () {
                        if (this.transitioning || !this.$element.hasClass('in')) return
                    
                        var startEvent = $.Event('hide.bs.collapse')
                        this.$element.trigger(startEvent)
                    Severity: Minor
                    Found in src/main/resources/static/js/bootstrap.js - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          self.timeout = setTimeout(function () {
                            if (self.hoverState == 'out') self.hide()
                          }, self.options.delay.hide)
                      Severity: Major
                      Found in src/main/resources/static/js/bootstrap.js and 1 other location - About 1 hr to fix
                      src/main/resources/static/js/bootstrap.js on lines 1390..1392

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 55.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language