Sign upLogin

ravikalla/online-bank

View on GitHub
Star

Showing 79 of 79 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  $.fn.carousel.noConflict = function () {
    $.fn.carousel = old
    return this
  }
Severity: Major
Found in src/main/resources/static/js/bootstrap.js and 8 other locations - About 40 mins to fix
src/main/resources/static/js/bootstrap.js on lines 161..164
src/main/resources/static/js/bootstrap.js on lines 273..276
src/main/resources/static/js/bootstrap.js on lines 728..731
src/main/resources/static/js/bootstrap.js on lines 899..902
src/main/resources/static/js/bootstrap.js on lines 1229..1232
src/main/resources/static/js/bootstrap.js on lines 2042..2045
src/main/resources/static/js/bootstrap.js on lines 2196..2199
src/main/resources/static/js/bootstrap.js on lines 2354..2357

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method toSomeoneElseTransfer has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public void toSomeoneElseTransfer(Recipient recipient, String accountType, String amount, PrimaryAccount primaryAccount, SavingsAccount savingsAccount) {
Severity: Minor
Found in src/main/java/in/ravikalla/cloudBank/service/UserServiceImpl/TransactionServiceImpl.java - About 35 mins to fix

    Method betweenAccountsTransfer has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public void betweenAccountsTransfer(String transferFrom, String transferTo, String amount, PrimaryAccount primaryAccount, SavingsAccount savingsAccount) throws Exception {
    Severity: Minor
    Found in src/main/java/in/ravikalla/cloudBank/service/UserServiceImpl/TransactionServiceImpl.java - About 35 mins to fix

      Method betweenAccountsTransfer has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          void betweenAccountsTransfer(String transferFrom, String transferTo, String amount, PrimaryAccount primaryAccount, SavingsAccount savingsAccount) throws Exception;
      Severity: Minor
      Found in src/main/java/in/ravikalla/cloudBank/service/TransactionService.java - About 35 mins to fix

        Method toSomeoneElseTransfer has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            void toSomeoneElseTransfer(Recipient recipient, String accountType, String amount, PrimaryAccount primaryAccount, SavingsAccount savingsAccount);
        Severity: Minor
        Found in src/main/java/in/ravikalla/cloudBank/service/TransactionService.java - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @RequestMapping(value = AppConstants.URI_DEPOSIT, method = RequestMethod.GET)
    public String deposit(Model model) {
        L.debug("68 : Start : AccountController.deposit(...)");

        model.addAttribute("accountType", "");
          Severity: Minor
          Found in src/main/java/in/ravikalla/cloudBank/controller/AccountController.java and 1 other location - About 35 mins to fix
          src/main/java/in/ravikalla/cloudBank/controller/AccountController.java on lines 87..96

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @RequestMapping(value = AppConstants.URI_WITHDRAW, method = RequestMethod.GET)
    public String withdraw(Model model) {

            L.debug("89 : Start : AccountController.withdraw(...)");
        model.addAttribute("accountType", "");
          Severity: Minor
          Found in src/main/java/in/ravikalla/cloudBank/controller/AccountController.java and 1 other location - About 35 mins to fix
          src/main/java/in/ravikalla/cloudBank/controller/AccountController.java on lines 67..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if (!selector) {
      selector = $this.attr('href')
      selector = selector && selector.replace(/.*(?=#[^\s]*$)/, '') // strip for ie7
    }
          Severity: Minor
          Found in src/main/resources/static/js/bootstrap.js and 1 other location - About 35 mins to fix
          src/main/resources/static/js/bootstrap.js on lines 107..110

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if (!selector) {
      selector = $this.attr('href')
      selector = selector && selector.replace(/.*(?=#[^\s]*$)/, '') // strip for ie7
    }
          Severity: Minor
          Found in src/main/resources/static/js/bootstrap.js and 1 other location - About 35 mins to fix
          src/main/resources/static/js/bootstrap.js on lines 2090..2093

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @RequestMapping(value = AppConstants.URI_DEPOSIT, method = RequestMethod.POST)
    public String depositPOST(@ModelAttribute("amount") String amount, @ModelAttribute("accountType") String accountType, Principal principal) {
          L.debug("79 : Start : AccountController.depositPOST(...)");
        accountService.deposit(accountType, Double.parseDouble(amount), principal);
        L.debug("82 : End : AccountController.depositPOST(...)");
          Severity: Minor
          Found in src/main/java/in/ravikalla/cloudBank/controller/AccountController.java and 1 other location - About 30 mins to fix
          src/main/java/in/ravikalla/cloudBank/controller/AccountController.java on lines 98..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @RequestMapping(value = AppConstants.URI_WITHDRAW, method = RequestMethod.POST)
    public String withdrawPOST(@ModelAttribute("amount") String amount, @ModelAttribute("accountType") String accountType, Principal principal) {
            L.debug("100 : Start : AccountController.withdrawPOST(...)");
        accountService.withdraw(accountType, Double.parseDouble(amount), principal);
        L.debug("102 : End : AccountController.withdrawPOST(...)");
          Severity: Minor
          Found in src/main/java/in/ravikalla/cloudBank/controller/AccountController.java and 1 other location - About 30 mins to fix
          src/main/java/in/ravikalla/cloudBank/controller/AccountController.java on lines 78..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              var self = obj instanceof this.constructor ?
      obj : $(obj.currentTarget).data('bs.' + this.type)
          Severity: Minor
          Found in src/main/resources/static/js/bootstrap.js and 1 other location - About 30 mins to fix
          src/main/resources/static/js/bootstrap.js on lines 1404..1405

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

              return false
          Severity: Major
          Found in src/main/resources/static/js/bootstrap.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              $.fn.popover.noConflict = function () {
    $.fn.popover = old
    return this
  }
            Severity: Minor
            Found in src/main/resources/static/js/bootstrap.js and 1 other location - About 30 mins to fix
            src/main/resources/static/js/bootstrap.js on lines 1771..1774

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                if (offsetBottom != null && (colliderTop + colliderHeight >= scrollHeight - offsetBottom)) return 'bottom'
            Severity: Major
            Found in src/main/resources/static/js/bootstrap.js - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  var self = obj instanceof this.constructor ?
      obj : $(obj.currentTarget).data('bs.' + this.type)
              Severity: Minor
              Found in src/main/resources/static/js/bootstrap.js and 1 other location - About 30 mins to fix
              src/main/resources/static/js/bootstrap.js on lines 1367..1368

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                $.fn.tooltip.noConflict = function () {
    $.fn.tooltip = old
    return this
  }
              Severity: Minor
              Found in src/main/resources/static/js/bootstrap.js and 1 other location - About 30 mins to fix
              src/main/resources/static/js/bootstrap.js on lines 1880..1883

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method signupPost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  @RequestMapping(value = AppConstants.HOME_SIGNUP, method = RequestMethod.POST)
    public String signupPost(@ModelAttribute("user") User user,  Model model) {
        L.debug("57 : Start : HomeController.signupPost(...)");
        if(userService.checkUserExists(user.getUsername(), user.getEmail()))  {
              Severity: Minor
              Found in src/main/java/in/ravikalla/cloudBank/controller/HomeController.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method createUser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public User createUser(User user, Set<UserRole> userRoles) {
        User localUser = userDao.findByUsername(user.getUsername());

        if (localUser != null) {
            LOG.info("User with username {} already exist. Nothing will be done. ", user.getUsername());
              Severity: Minor
              Found in src/main/java/in/ravikalla/cloudBank/service/UserServiceImpl/UserServiceImpl.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language