Sign upLogin

rdfio/RDFIO

View on GitHub
Star
classes/parsers/RDFIO_ARC2ToWikiConverter.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function convert has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function convert( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes ) {
        // Instatiate wiki title converters (converting from URI and related RDF data to Wiki Title)
        $uriToTitleConv = new RDFIOURIToWikiTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
        $uriToPropTitleConv = new RDFIOURIToPropertyTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
Severity: Minor
Found in classes/parsers/RDFIO_ARC2ToWikiConverter.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method convert has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function convert( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes ) {
        // Instatiate wiki title converters (converting from URI and related RDF data to Wiki Title)
        $uriToTitleConv = new RDFIOURIToWikiTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
        $uriToPropTitleConv = new RDFIOURIToPropertyTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
Severity: Major
Found in classes/parsers/RDFIO_ARC2ToWikiConverter.php - About 3 hrs to fix

    The method convert() has 129 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function convert( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes ) {
        // Instatiate wiki title converters (converting from URI and related RDF data to Wiki Title)
        $uriToTitleConv = new RDFIOURIToWikiTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
        $uriToPropTitleConv = new RDFIOURIToPropertyTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
    Severity: Minor
    Found in classes/parsers/RDFIO_ARC2ToWikiConverter.php by phpmd

    The method convert() has a Cyclomatic Complexity of 33. The configured cyclomatic complexity threshold is 10.
    Open

        public function convert( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes ) {
        // Instatiate wiki title converters (converting from URI and related RDF data to Wiki Title)
        $uriToTitleConv = new RDFIOURIToWikiTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
        $uriToPropTitleConv = new RDFIOURIToPropertyTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
    Severity: Minor
    Found in classes/parsers/RDFIO_ARC2ToWikiConverter.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Missing class import via use statement (line '22', column '25').
    Open

            $uriToTitleConv = new RDFIOURIToWikiTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
    Severity: Minor
    Found in classes/parsers/RDFIO_ARC2ToWikiConverter.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '129', column '17').
    Open

                            throw new RDFIOARC2ToWikiConverterException( 'Error in ARC2ToWikiConverter: Unknown type ("' . $triple['o_type'] . '") of object ("' . $triple['o'] . '") in triple! (not "uri" nor "literal")!' );
    Severity: Minor
    Found in classes/parsers/RDFIO_ARC2ToWikiConverter.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '198', column '39').
    Open

                $this->wikiPages[$pageTitle] = new RDFIOWikiPage( $pageTitle );
    Severity: Minor
    Found in classes/parsers/RDFIO_ARC2ToWikiConverter.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '23', column '29').
    Open

            $uriToPropTitleConv = new RDFIOURIToPropertyTitleConverter( $arc2Triples, $arc2ResourceIndex, $arc2NSPrefixes );
    Severity: Minor
    Found in classes/parsers/RDFIO_ARC2ToWikiConverter.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method convert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                // Separate handling for properties
                $propertyTitle = $uriToPropTitleConv->convert( $triple['p'] );
                // Add the property namespace to property title
                $propTitleWithNS = Title::makeTitleSafe( SMW_NS_PROPERTY, $propertyTitle )->getFullText();
    Severity: Minor
    Found in classes/parsers/RDFIO_ARC2ToWikiConverter.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    There are no issues that match your filters.

    Category
    Status