Sign upLogin

rdfio/rdf2smw

View on GitHub
Star
components/mwxmlcreator.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method MWXMLCreator.Run has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
Open

func (p *MWXMLCreator) Run() {
    tplPropertyIdx := make(map[string]map[string]int)

    defer close(p.OutTemplates)
    defer close(p.OutProperties)
Severity: Minor
Found in components/mwxmlcreator.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method MWXMLCreator.Run has 72 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p *MWXMLCreator) Run() {
    tplPropertyIdx := make(map[string]map[string]int)

    defer close(p.OutTemplates)
    defer close(p.OutProperties)
Severity: Minor
Found in components/mwxmlcreator.go - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    func escapeWikiChars(inStr string) string {
    outStr := str.Replace(inStr, "[", "(", -1)
    outStr = str.Replace(outStr, "]", ")", -1)
    outStr = str.Replace(outStr, "|", ",", -1)
    outStr = str.Replace(outStr, "=", "-", -1)
    Severity: Minor
    Found in components/mwxmlcreator.go and 1 other location - About 45 mins to fix
    components/iptypes.go on lines 103..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    exported function NewMWXMLCreator should have comment or be unexported
    Open

    func NewMWXMLCreator(useTemplates bool) *MWXMLCreator {
    Severity: Minor
    Found in components/mwxmlcreator.go by golint

    const wikiXmlTpl should be wikiXMLTpl
    Open

    const wikiXmlTpl = `
    Severity: Minor
    Found in components/mwxmlcreator.go by golint

    exported method MWXMLCreator.Run should have comment or be unexported
    Open

    func (p *MWXMLCreator) Run() {
    Severity: Minor
    Found in components/mwxmlcreator.go by golint

    exported type MWXMLCreator should have comment or be unexported
    Open

    type MWXMLCreator struct {
    Severity: Minor
    Found in components/mwxmlcreator.go by golint

    There are no issues that match your filters.

    Category
    Status