Sign upLogin

reduct/component

View on GitHub
Star

Showing 8 of 8 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('@reduct/component: utilities.isFunction', () => {
    it('should return a negative result if no value was passed.', () => {
        expect(isFunction()).to.equal(false);
    });
Severity: Major
Found in src/utilities/isFunction.spec.js and 1 other location - About 1 day to fix
src/utilities/isDefined.spec.js on lines 4..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 304.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('@reduct/component: utilities.isDefined', () => {
    it('should return a negative result if no value was passed.', () => {
        expect(isDefined()).to.equal(false);
    });
Severity: Major
Found in src/utilities/isDefined.spec.js and 1 other location - About 1 day to fix
src/utilities/isFunction.spec.js on lines 4..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 304.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function setState has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    setState(delta = {}, opts = {silent: false}) {
        const isNotSilent = !opts.silent;
        const previousState = cloneObject(this.state);
        const {initialStateKeys} = this;
Severity: Minor
Found in src/component.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _validateAndSetProps has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function _validateAndSetProps(context, passedProps) {
    const {
        el,
        getDefaultProps
    } = context;
Severity: Minor
Found in src/component.js - About 1 hr to fix

    Function setState has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        setState(delta = {}, opts = {silent: false}) {
        const isNotSilent = !opts.silent;
        const previousState = cloneObject(this.state);
        const {initialStateKeys} = this;
    Severity: Minor
    Found in src/component.js - About 1 hr to fix

      Function component has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      export const component = decoratorPropTypes => CustomComponent => {
    const prototype = extractFrom(CustomComponent);
    const propTypes = decoratorPropTypes || CustomComponent.propTypes || {};
    const componentName = CustomComponent.name;
      Severity: Minor
      Found in src/component.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it('should return an empty object if no getInitialState() method was present.', () => {
        const instanceWithoutDefaults = new ComponentWithoutDefaults();

        expect(instanceWithoutDefaults.getInitialState()).to.be.an('object');
    });
      Severity: Minor
      Found in src/component.state.spec.js and 1 other location - About 55 mins to fix
      src/component.prop.spec.js on lines 54..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it('should return an empty object if no getDefaultProps() method was specified in the extended Class.', () => {
        const instance = new ComponentWithoutDefaults();

        expect(instance.getDefaultProps()).to.be.an('object');
    });
      Severity: Minor
      Found in src/component.prop.spec.js and 1 other location - About 55 mins to fix
      src/component.state.spec.js on lines 104..108

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language