lib/relaton_nist/tech_pubs_parser.rb
Class TechPubsParser
has 25 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class TechPubsParser
RELATION_TYPES = {
"replaces" => "obsoletes",
"isVersionOf" => "editionOf",
"hasTranslation" => "hasTranslation",
Method forename_initial
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
def forename_initial(person) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
fnames = []
fname = person.at("given_name")&.text
if fname
if /^(?:(?<name>\w+)\s)?(?<inits>(?:\w(?:\.|\b)\s?)+)/ =~ fname
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse_date
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def parse_date
@doc.xpath("publication_date|approval_date").map do |dt|
on = dt.at("year").text
if (m = dt.at "month")
on += "-#{m.text}"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"