Sign upLogin

resource-watch/document-adapter

View on GitHub
Star

Showing 92 of 92 total issues

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    async delete(data) {
        const taskMessage = task.createMessage(task.MESSAGE_TYPES.TASK_DELETE, data);
        await this.sendMessage(taskMessage);
    }
Severity: Major
Found in app/src/services/taskQueueService.js and 6 other locations - About 35 mins to fix
app/src/services/taskQueueService.js on lines 29..32
app/src/services/taskQueueService.js on lines 34..37
app/src/services/taskQueueService.js on lines 39..42
app/src/services/taskQueueService.js on lines 44..47
app/src/services/taskQueueService.js on lines 49..52
app/src/services/taskQueueService.js on lines 59..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    async overwrite(data) {
        const taskMessage = task.createMessage(task.MESSAGE_TYPES.TASK_OVERWRITE, data);
        await this.sendMessage(taskMessage);
    }
Severity: Major
Found in app/src/services/taskQueueService.js and 6 other locations - About 35 mins to fix
app/src/services/taskQueueService.js on lines 29..32
app/src/services/taskQueueService.js on lines 39..42
app/src/services/taskQueueService.js on lines 44..47
app/src/services/taskQueueService.js on lines 49..52
app/src/services/taskQueueService.js on lines 54..57
app/src/services/taskQueueService.js on lines 59..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    async deleteIndex(data) {
        const taskMessage = task.createMessage(task.MESSAGE_TYPES.TASK_DELETE_INDEX, data);
        await this.sendMessage(taskMessage);
    }
Severity: Major
Found in app/src/services/taskQueueService.js and 6 other locations - About 35 mins to fix
app/src/services/taskQueueService.js on lines 29..32
app/src/services/taskQueueService.js on lines 34..37
app/src/services/taskQueueService.js on lines 39..42
app/src/services/taskQueueService.js on lines 44..47
app/src/services/taskQueueService.js on lines 49..52
app/src/services/taskQueueService.js on lines 54..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    async append(data) {
        const taskMessage = task.createMessage(task.MESSAGE_TYPES.TASK_APPEND, data);
        await this.sendMessage(taskMessage);
    }
Severity: Major
Found in app/src/services/taskQueueService.js and 6 other locations - About 35 mins to fix
app/src/services/taskQueueService.js on lines 29..32
app/src/services/taskQueueService.js on lines 34..37
app/src/services/taskQueueService.js on lines 39..42
app/src/services/taskQueueService.js on lines 49..52
app/src/services/taskQueueService.js on lines 54..57
app/src/services/taskQueueService.js on lines 59..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return null;
Severity: Major
Found in app/src/serializers/csvSerializer.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return null;
    Severity: Major
    Found in app/src/serializers/jsonSerializer.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return null;
      Severity: Major
      Found in app/src/services/queryService.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return right;
        Severity: Major
        Found in app/src/services/queryService.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return {
                data: data.hits.hits.map((el) => {
                    // eslint-disable-next-line no-underscore-dangle
                    const formatted = CSVSerializer.formatAlias(Object.assign(el._source, {
                        _id: el._id
          Severity: Major
          Found in app/src/serializers/csvSerializer.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return {
                data: data.hits.hits.map((el) => {
                    // eslint-disable-next-line no-underscore-dangle
                    const formatted = JSONSerializer.formatAlias(Object.assign(el._source, {
                        _id: el._id
            Severity: Major
            Found in app/src/serializers/jsonSerializer.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return left;
              Severity: Major
              Found in app/src/services/queryService.js - About 30 mins to fix

                Function sendMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    async sendMessage(msg, retryOnChannelClosed = true) {
        logger.info(`Sending message to ${this.q}`, msg);
        try {
            // Sending to queue
            await this.isInit;
                Severity: Minor
                Found in app/src/services/taskQueueService.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language