restocat/restocat

View on GitHub

Showing 19 of 19 total issues

Function requestListener has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async requestListener(request, response) {
    request.time = response.time = Date.now();
    request.uuid = helpers.uuid();

    this._events.emit('incomingMessage', request);
Severity: Minor
Found in lib/router/RequestRouter.js - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      if (data instanceof Error) {
        if (!(data instanceof httpErrors.HttpError)) {
          data = new httpErrors.InternalServerError(String(data));
        }
    
    
    Severity: Major
    Found in lib/formatters/json.js and 2 other locations - About 1 hr to fix
    lib/formatters/binary.js on lines 13..19
    lib/formatters/text.js on lines 12..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      if (data instanceof Error) {
        if (!(data instanceof httpErrors.HttpError)) {
          data = new httpErrors.InternalServerError(String(data));
        }
    
    
    Severity: Major
    Found in lib/formatters/text.js and 2 other locations - About 1 hr to fix
    lib/formatters/binary.js on lines 13..19
    lib/formatters/json.js on lines 17..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      if (data instanceof Error) {
        if (!(data instanceof httpErrors.HttpError)) {
          data = new httpErrors.InternalServerError(String(data));
        }
    
    
    Severity: Major
    Found in lib/formatters/binary.js and 2 other locations - About 1 hr to fix
    lib/formatters/json.js on lines 17..23
    lib/formatters/text.js on lines 12..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _createDescriptor has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _createDescriptor(filename) {
        if (!filename) {
          return null;
        }
    
    
    Severity: Minor
    Found in lib/finders/CollectionsFinder.js - About 1 hr to fix

      Function _getContentType has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        _getContentType(context) {
          let type = context.response.getHeader('Content-Type');
      
          if (!type) {
            if (context.request.accepts(this.acceptable)) {
      Severity: Minor
      Found in lib/FormatterProvider.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function send has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      ServerResponse.prototype.send = function send(code, body, headers) {
        if (code === undefined) {
          this.statusCode = 200;
        } else if (code.constructor.name === 'Number') {
          this.statusCode = code;
      Severity: Minor
      Found in lib/http/ServerResponse.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getFormatter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        getFormatter(context) {
          let formatter;
      
          if (this.formatters === null) {
            this._prepareFormatters();
      Severity: Minor
      Found in lib/FormatterProvider.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function match has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        match(path) {
          if (!path) {
            return false;
          }
      
      
      Severity: Minor
      Found in lib/router/Route.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function header has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      ServerResponse.prototype.setHeader = function header(name, value) {
        if (value === undefined) {
          return null;
        }
      
      
      Severity: Minor
      Found in lib/http/ServerResponse.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getContentLength has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      IncomingMessage.prototype.getContentLength = function getContentLength() {
        if (this._clen !== undefined) {
          return (this._clen === false ? undefined : this._clen);
        }
      
      
      Severity: Minor
      Found in lib/http/IncomingMessage.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return this.errorHandler(request, response, reason);
      Severity: Major
      Found in lib/router/RequestRouter.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return {
              name: collection_name,
              path: pathCollectionJson,
              properties,
              directory,
        Severity: Major
        Found in lib/finders/CollectionsFinder.js - About 30 mins to fix

          Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            constructor(locator) {
          
              /**
               * Service Locator
               * @type {ServiceLocator}
          Severity: Minor
          Found in lib/Server.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _getCollection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            _getCollection(descriptor) {
              const logic_path = this._getLogicPath(descriptor);
          
              let constructor;
              try {
          Severity: Minor
          Found in lib/loaders/CollectionsLoader.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getContentType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          IncomingMessage.prototype.getContentType = function getContentType() {
            if (this._contentType !== undefined) {
              return (this._contentType);
            }
          
          
          Severity: Minor
          Found in lib/http/IncomingMessage.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _createDescriptor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            _createDescriptor(filename) {
              if (!filename) {
                return null;
              }
          
          
          Severity: Minor
          Found in lib/finders/CollectionsFinder.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function requestListener has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            async requestListener(request, response) {
              request.time = response.time = Date.now();
              request.uuid = helpers.uuid();
          
              this._events.emit('incomingMessage', request);
          Severity: Minor
          Found in lib/router/RequestRouter.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function errorHandler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            async errorHandler(request, response, error) {
              const $context = this._contextFactory.create(request, response);
          
              if (!error) {
                error = new httpErrors.InternalServerError('Call error handler without error');
          Severity: Minor
          Found in lib/router/RequestRouter.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language