rgmining/fraud-eagle

View on GitHub

Showing 59 of 59 total issues

File graph.py has 488 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#
#  graph.py
#
#  Copyright (c) 2016-2023 Junpei Kawamoto
#
Severity: Minor
Found in fraud_eagle/graph.py - About 7 hrs to fix

    Function psi has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    def psi(u_label: UserLabel, p_label: ProductLabel, r_label: ReviewLabel, epsilon: float) -> float:
        """Likelihood of a pair of user and product.
    
        The likelihood is dependent on the review of the user gives the product.
        The review is one of {+, -}. We defined constant representing "+" and "-",
    Severity: Minor
    Found in fraud_eagle/likelihood.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in function psi. (15)
    Open

    def psi(u_label: UserLabel, p_label: ProductLabel, r_label: ReviewLabel, epsilon: float) -> float:
        """Likelihood of a pair of user and product.
    
        The likelihood is dependent on the review of the user gives the product.
        The review is one of {+, -}. We defined constant representing "+" and "-",
    Severity: Minor
    Found in fraud_eagle/likelihood.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in method update. (10)
    Open

        def update(self) -> float:
            """Update reviewers' anomalous scores and products' summaries.
    
            For each user :math:`u`, update messages to every product :math:`p`
            the user reviews. The message function :math:`m_{u\\rightarrow p}`
    Severity: Minor
    Found in fraud_eagle/graph.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function update has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def update(self) -> float:
            """Update reviewers' anomalous scores and products' summaries.
    
            For each user :math:`u`, update messages to every product :math:`p`
            the user reviews. The message function :math:`m_{u\\rightarrow p}`
    Severity: Minor
    Found in fraud_eagle/graph.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_review has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def add_review(self, reviewer: Reviewer, product: Product, rating: float, *_args: Any, **_kwargs: Any) -> Review:
    Severity: Minor
    Found in fraud_eagle/graph.py - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

                      return epsilon
      Severity: Major
      Found in fraud_eagle/likelihood.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return 1 - 2 * epsilon
        Severity: Major
        Found in fraud_eagle/likelihood.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return 2 * epsilon
          Severity: Major
          Found in fraud_eagle/likelihood.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return 1 - epsilon
            Severity: Major
            Found in fraud_eagle/likelihood.py - About 30 mins to fix

              Line too long (100 > 79 characters)
              Open

                          b[u_label] = phi_u(u_label) + self.graph.prod_message_from_products(self, None, u_label)
              Severity: Minor
              Found in fraud_eagle/graph.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (81 > 79 characters)
              Open

                      ratings = [self.graph.retrieve_review(r, self).rating for r in reviewers]
              Severity: Minor
              Found in fraud_eagle/graph.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (82 > 79 characters)
              Open

                        where :math:`u` and :math:`p` is the user and the product, respectively.
              Severity: Minor
              Found in fraud_eagle/graph.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (81 > 79 characters)
              Open

                      """Compute an updated message from a product to a user with a user label.
              Severity: Minor
              Found in fraud_eagle/graph.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (82 > 79 characters)
              Open

                      :data:`ReviewLabel.PLUS<fraud_eagle.labels.ReviewLabel.PLUS>` is returned.
              Severity: Minor
              Found in fraud_eagle/graph.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (84 > 79 characters)
              Open

                      """Compute an updated message from a user to a product with a product label.
              Severity: Minor
              Found in fraud_eagle/graph.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (84 > 79 characters)
              Open

                     \\phi_{i}^{\\cal{U}}: \\cal{L}_{\\cal{U}} \\rightarrow \\mathbb{R}_{\\geq 0},
              Severity: Minor
              Found in fraud_eagle/prior.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (103 > 79 characters)
              Open

                                  message_to_user[u_label] = self._update_product_to_user(reviewer, product, u_label)
              Severity: Minor
              Found in fraud_eagle/graph.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (92 > 79 characters)
              Open

                  def prod_message_from_all_users(self, product: Product, p_label: ProductLabel) -> float:
              Severity: Minor
              Found in fraud_eagle/graph.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (84 > 79 characters)
              Open

                     \\phi_{j}^{\\cal{P}}: \\cal{L}_{\\cal{P}} \\rightarrow \\mathbb{R}_{\\geq 0},
              Severity: Minor
              Found in fraud_eagle/prior.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.
              Severity
              Category
              Status
              Source
              Language