Sign upLogin

ringcentral-ruby/lita-glip

View on GitHub
Star

Showing 57 of 57 total issues

Line is too long. [87/80]
Open

            Lita.logger.debug("#{@logger_prefix}Send Message To Glip From Lita: #{s}.")
Severity: Minor
Found in lib/lita/adapters/glip/connector.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          unless (m['body'].key?(TYPE_PROPERTY_A) && m['body'][TYPE_PROPERTY_A] == "PostAdded") ||
Severity: Minor
Found in lib/lita/adapters/glip/message_handler.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [81/80]
Open

              return Lita::Room.create_or_update room_id, name: glip_room['name']
Severity: Minor
Found in lib/lita/adapters/glip/room_creator.rb by rubocop

Line is too long. [87/80]
Open

            "#{glip_user['firstName']} #{glip_user['lastName']}".gsub(/\s+/, ' ').strip
Severity: Minor
Found in lib/lita/adapters/glip/user_creator.rb by rubocop

Missing top-level class documentation comment.
Open

      class Connector
Severity: Minor
Found in lib/lita/adapters/glip/connector.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

            (m['body'].key?(TYPE_PROPERTY_B) && m['body'][TYPE_PROPERTY_B] == "PostAdded")
Severity: Minor
Found in lib/lita/adapters/glip/message_handler.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency glip_sdk should appear before lita.
Open

  spec.add_runtime_dependency 'glip_sdk', '~> 0', '>= 0.0.5'
Severity: Minor
Found in lita-glip.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

Missing top-level module documentation comment.
Open

  module Adapters
Severity: Minor
Found in lib/lita/adapters/glip.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

      class RoomCreator
Severity: Minor
Found in lib/lita/adapters/glip/room_creator.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Final newline missing.
Open

gemspec
Severity: Minor
Found in Gemfile by rubocop

Trailing whitespace detected.
Open

              Lita.logger.debug("Created New User With User Name [#{glip_user['id']}][#{glip_user_name}]")
Severity: Minor
Found in lib/lita/adapters/glip/user_creator.rb by rubocop

Line is too long. [117/80]
Open

              Lita.logger.debug("Created New User With User Name [#{glip_user['id']}][#{glip_user_name}]")
Severity: Minor
Found in lib/lita/adapters/glip/user_creator.rb by rubocop

Freeze mutable objects assigned to constants.
Open

        TYPE_PROPERTY_A = 'eventType'
Severity: Minor
Found in lib/lita/adapters/glip/message_handler.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Missing space after #.
Open

  #spec.files         = Dir['lib/**/**/*']
Severity: Minor
Found in lita-glip.gemspec by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Line is too long. [90/80]
Open

            (m['body'].key?(TYPE_PROPERTY_B) && m['body'][TYPE_PROPERTY_B] == "PostAdded")
Severity: Minor
Found in lib/lita/adapters/glip/message_handler.rb by rubocop

Freeze mutable objects assigned to constants.
Open

        TYPE_PROPERTY_B = 'messageType'
Severity: Minor
Found in lib/lita/adapters/glip/message_handler.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency coveralls should appear before simplecov.
Open

  spec.add_development_dependency 'coveralls', '~> 0'
Severity: Minor
Found in lita-glip.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

Prefer $INPUT_RECORD_SEPARATOR or $RS from the stdlib 'English' module (don't forget to require it) over $/.
Open

  spec.files         = `git ls-files`.split($/)
Severity: Minor
Found in lita-glip.gemspec by rubocop

Final newline missing.
Open

end
Severity: Minor
Found in lib/lita/adapters/glip/connector.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

source "https://rubygems.org"
Severity: Minor
Found in Gemfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"
Severity
Category
Status
Source
Language