ringcentral-ruby/lita-glip

View on GitHub

Showing 57 of 57 total issues

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

require "rspec/core/rake_task"
Severity: Minor
Found in Rakefile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [96/80]
Open

        def initialize(robot, app_key, app_secret, server, username, extension, password, token)
Severity: Minor
Found in lib/lita/adapters/glip/connector.rb by rubocop

Missing top-level class documentation comment.
Open

      class MessageHandler

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Extra empty line detected at class body end.
Open


      end
Severity: Minor
Found in lib/lita/adapters/glip/connector.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [118/80]
Open

            Lita.logger.warn("#{@logger_prefix}Glip Lita: Glip Message Received without body: #{MultiJson.encode(m)}")

Line is too long. [98/80]
Open

          unless (m['body'].key?(TYPE_PROPERTY_A) && m['body'][TYPE_PROPERTY_A] == "PostAdded") ||

Use %q only for strings that contain both single quotes and double quotes.
Open

  spec.summary       = %q{A Glip adapter for the Lita chat robot.}
Severity: Minor
Found in lita-glip.gemspec by rubocop

Line is too long. [99/80]
Open

          unless m.is_a?(Hash) && m.key?('event') && m['event'].index('/glip/posts').is_a?(Integer)

Align the operands of a condition in an unless statement spanning multiple lines.
Open

            (m['body'].key?(TYPE_PROPERTY_B) && m['body'][TYPE_PROPERTY_B] == "PostAdded")

This cop checks the indentation of the right hand side operand in binary operations that span more than one line.

Example:

# bad
if a +
b
  something
end

# good
if a +
   b
  something
end

Method Lita::Adapters::Glip#initialize is defined at both lib/lita/adapters/glip.rb:22 and lib/lita/adapters/glip.rb:30.
Open

      def initialize(robot)
Severity: Minor
Found in lib/lita/adapters/glip.rb by rubocop

This cop checks for duplicated instance (or singleton) method definitions.

Example:

# bad

def duplicated
  1
end

def duplicated
  2
end

Example:

# bad

def duplicated
  1
end

alias duplicated other_duplicated

Example:

# good

def duplicated
  1
end

def other_duplicated
  2
end

Line is too long. [101/80]
Open

              Lita.logger.debug("Glip API Response: User Name: #{glip_user_name}/#{res.body['id']}.")

The name of this source file (lita-glip.rb) should use snake_case.
Open

require 'lita'
Severity: Minor
Found in lib/lita-glip.rb by rubocop

This cop makes sure that Ruby source files have snake_case names. Ruby scripts (i.e. source files with a shebang in the first line) are ignored.

Example:

# bad
lib/layoutManager.rb

anything/usingCamelCase

# good
lib/layout_manager.rb

anything/using_snake_case.rake

Missing top-level class documentation comment.
Open

      class UserCreator

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

%q-literals should be delimited by ( and ).
Open

  spec.description   = %q{A Glip adapter for Lita.}
Severity: Minor
Found in lita-glip.gemspec by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Use %q only for strings that contain both single quotes and double quotes.
Open

  spec.description   = %q{A Glip adapter for Lita.}
Severity: Minor
Found in lita-glip.gemspec by rubocop

Line is too long. [104/80]
Open

          Lita.logger.debug("#{@logger_prefix}Glip Lita: Glip Message Received: #{MultiJson.encode(m)}")

Line is too long. [83/80]
Open

      config :server_url, type: String, default: 'platform.devtest.ringcentral.com'
Severity: Minor
Found in lib/lita/adapters/glip.rb by rubocop
Severity
Category
Status
Source
Language