Sign upLogin

rkday/ruby-diameter

View on GitHub
Star
lib/diameter/avp.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class AVP has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

  class AVP
    include Internals
    include Constants::AVPType
    attr_reader :code, :mandatory, :vendor_id
Severity: Minor
Found in lib/diameter/avp.rb - About 3 hrs to fix

    Method to_s has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_s
      has_all_ascii_values =
        @content.bytes.reject { |c| (32 < c && c < 126) }.empty?

      could_be_32bit_num = (@content.length == 4)
    Severity: Minor
    Found in lib/diameter/avp.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status