Sign upLogin

rkday/ruby-diameter

View on GitHub
Star
lib/diameter/stack.rb

Summary

Maintainability
C
1 day
Test Coverage

File stack.rb has 274 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'uri'
require 'socket'
require 'diameter/peer'
require 'diameter/message'
require 'diameter/stack_transport_helpers'
Severity: Minor
Found in lib/diameter/stack.rb - About 2 hrs to fix

    Class Stack has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Stack
    include Internals

    # @!group Setup methods
    Severity: Minor
    Found in lib/diameter/stack.rb - About 2 hrs to fix

      Method send_request has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def send_request(req, options={})
      fail "Must pass a request" unless req.request
      req.add_origin_host_and_realm(@local_host, @local_realm)

      peer = options[:peer]
      Severity: Minor
      Found in lib/diameter/stack.rb - About 1 hr to fix

        Method handle_message has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def handle_message(msg_bytes, cxn)
      # Common processing - ensure that this message has come in on this
      # peer's expected connection, and update the last time we saw
      # activity on this peer
      msg = Message.from_bytes(msg_bytes)
        Severity: Minor
        Found in lib/diameter/stack.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method send_request has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def send_request(req, options={})
      fail "Must pass a request" unless req.request
      req.add_origin_host_and_realm(@local_host, @local_realm)

      peer = options[:peer]
        Severity: Minor
        Found in lib/diameter/stack.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method app_avps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def app_avps
      avps = []
      
      @auth_apps.each do |app_id, vendor|
        avps << if vendor == 0
        Severity: Minor
        Found in lib/diameter/stack.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              @acct_apps.each do |app_id, vendor|
        avps << if vendor == 0
                  AVP.create("Acct-Application-Id", app_id)
                else
                  AVP.create("Vendor-Specific-Application-Id",
        Severity: Minor
        Found in lib/diameter/stack.rb and 1 other location - About 15 mins to fix
        lib/diameter/stack.rb on lines 319..325

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              @auth_apps.each do |app_id, vendor|
        avps << if vendor == 0
                  AVP.create("Auth-Application-Id", app_id)
                else
                  AVP.create("Vendor-Specific-Application-Id",
        Severity: Minor
        Found in lib/diameter/stack.rb and 1 other location - About 15 mins to fix
        lib/diameter/stack.rb on lines 329..335

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status