Sign upLogin

robotdance/php-json-schema

View on GitHub
Star

Showing 177 of 177 total issues

Avoid using static access to class '\robotdance\I18n' in method 'check'.
Open

            $errorMsg = I18n::t("constraints.type.required", ['actual' => ucwords(gettype($value)), 'required' => self::$wording[$type]]);
Severity: Minor
Found in src/JsonSchema/Constraints/TypeConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\robotdance\I18n' in method 'validateCommonProperties'.
Open

                        $errorMsg = I18n::t("constraints.undefined.required", ['property' => $required]);
Severity: Minor
Found in src/JsonSchema/Constraints/UndefinedConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\robotdance\I18n' in method 'validateCommonProperties'.
Open

                    $errorMsg = I18n::t("constraints.undefined.required_missing");
Severity: Minor
Found in src/JsonSchema/Constraints/UndefinedConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\JsonSchema\Rfc3339' in method 'check'.
Open

                if (null === Rfc3339::createFromString($element)) {
Severity: Minor
Found in src/JsonSchema/Constraints/FormatConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DateTime' in method 'validateDateTime'.
Open

        $dt = \DateTime::createFromFormat($format, $datetime);
Severity: Minor
Found in src/JsonSchema/Constraints/FormatConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method check() has an NPath complexity of 576. The configured NPath complexity threshold is 200.
Open

    public function check($element, $schema = null, $path = null, $i = null)
    {
        // Verify minimum
        if (isset($schema->exclusiveMinimum)) {
            if (isset($schema->minimum)) {
Severity: Minor
Found in src/JsonSchema/Constraints/NumberConstraint.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid using static access to class '\robotdance\I18n' in method 'check'.
Open

                $errorMsg = I18n::t("constraints.number.minimum", ['value' => $schema->minimum]);
Severity: Minor
Found in src/JsonSchema/Constraints/NumberConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\robotdance\I18n' in method 'check'.
Open

            $errorMsg = I18n::t("constraints.collection.max_items", ['maxItems' => $schema->maxItems]);
Severity: Minor
Found in src/JsonSchema/Constraints/CollectionConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\robotdance\I18n' in method 'check'.
Open

                    $errorMsg = I18n::t("constraints.format.time", ['time' => json_encode($element)]);
Severity: Minor
Found in src/JsonSchema/Constraints/FormatConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method validateType() has an NPath complexity of 2048. The configured NPath complexity threshold is 200.
Open

    protected function validateType($value, $type)
    {
        //mostly the case for inline schema
        if (!$type) {
            return true;
Severity: Minor
Found in src/JsonSchema/Constraints/TypeConstraint.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method validateCommonProperties() has an NPath complexity of 4536. The configured NPath complexity threshold is 200.
Open

    protected function validateCommonProperties($value, $schema = null, $path = null, $i = "")
    {
        // if it extends another schema, it must pass that schema as well
        if (isset($schema->extends)) {
            if (is_string($schema->extends)) {
Severity: Minor
Found in src/JsonSchema/Constraints/UndefinedConstraint.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method incrementPath uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $path = $i;
        }
Severity: Minor
Found in src/JsonSchema/Constraints/Constraint.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method check() has 110 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    public function check($element, $schema = null, $path = null, $i = null)
    {
        if (!isset($schema->format)) {
            return;
        }
Severity: Minor
Found in src/JsonSchema/Constraints/FormatConstraint.php by phpmd

Avoid using static access to class '\robotdance\I18n' in method 'check'.
Open

                    $errorMsg = I18n::t("constraints.format.email");
Severity: Minor
Found in src/JsonSchema/Constraints/FormatConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\robotdance\I18n' in method 'check'.
Open

            $errorMsg = I18n::t("constraints.string.max_length", ['maxLength' => $schema->maxLength]);
Severity: Minor
Found in src/JsonSchema/Constraints/StringConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\robotdance\I18n' in method 'check'.
Open

            $errorMsg = I18n::t("constraints.string.min_length", ['minLength' => $schema->minLength]);
Severity: Minor
Found in src/JsonSchema/Constraints/StringConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method validateCommonProperties uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $this->checkUndefined($value, $schema->extends, $path, $i);
            }
Severity: Minor
Found in src/JsonSchema/Constraints/UndefinedConstraint.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$date'.
Open

                if (!$date = $this->validateDateTime($element, 'Y-m-d')) {
Severity: Minor
Found in src/JsonSchema/Constraints/FormatConstraint.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The method check uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $errorMsg = I18n::t("constraints.number.exclusive_minimum");
                $this->addError($path, $errorMsg, 'missingMinimum');
            }
Severity: Minor
Found in src/JsonSchema/Constraints/NumberConstraint.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\robotdance\I18n' in method 'validateElement'.
Open

                $errorMsg = I18n::t("constraints.object.additional_properties", ['property' => $i]);
Severity: Minor
Found in src/JsonSchema/Constraints/ObjectConstraint.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language