robotomize/fujes

View on GitHub
src/robotomize/Fujes/SearchFactory.php

Summary

Maintainability
A
50 mins
Test Coverage

Method find has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $urlName,
        $matchString,
        $depth = 1,
        $jsonEncode = true,
        $multipleResult = false,
Severity: Major
Found in src/robotomize/Fujes/SearchFactory.php - About 50 mins to fix

    The method find has a boolean flag argument $jsonEncode, which is a certain sign of a Single Responsibility Principle violation.
    Open

            $jsonEncode = true,

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
        public function bar($flag = true) {
        }
    }

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method find has a boolean flag argument $multipleResult, which is a certain sign of a Single Responsibility Principle violation.
    Open

            $multipleResult = false,

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
        public function bar($flag = true) {
        }
    }

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    There are no issues that match your filters.

    Category
    Status